From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Sun, 23 Nov 2014 18:18:17 +0100 Subject: [Buildroot] [PATCH 3/4] pkg-infra: differentiate remote tarball name from local filename In-Reply-To: <20141123170640.GB11143@free.fr> References: <9c560fb0f335f99d5350617f0368ae591e46e837.1416068005.git.yann.morin.1998@free.fr> <546BB223.9020600@mind.be> <20141123170640.GB11143@free.fr> Message-ID: <20141123171817.GC11143@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Arnout, All, On 2014-11-23 18:06 +0100, Yann E. MORIN spake thusly: > On 2014-11-18 21:54 +0100, Arnout Vandecappelle spake thusly: > > On 15/11/14 17:19, Yann E. MORIN wrote: > > > Some upstreams may use a naming scheme that does not fit well in how > > > Buildroot wants to handle filenames. > > > > > > For example, GitHub used to have a scheme like: > > > https://github.com/USER/REPO/archive/VERSION.tar.gz > > > > > > which means we would have a local file named VERSION.tar.gz, when we > > > want to have PKG-VERSION.tar.gz > > > > > > Other forges are also known to have similar schemes. Google Code, for > > > example, may also use similarly named files. > > > > > > Introduce a new variable, FOO_UPSTREAM_SOURCE, which the package may set > > > in that case. If not set, it defaults to FOO_SOURCE. > > > > Instead of this, I was thinking of the reverse approach: define FOO_LOCAL_SOURCE. > > OK, will change. Well, actually, I'm not convinced. What I've done is add FOO_LOCAL_SOURCE, which defaults to FOO_SOURCE if not defined: ifndef $(2)_LOCAL_SOURCE $(2)_LOCAL_SOURCE = $$($(2)_SOURCE) endif But then, here's what I thought about: - if both upstream and local are the same, we just have to define FOO_SOURCE and be done with it; - furthermore, if the value of FOO_SOURCE is the default PKG-VERSION.tar.gz, we need not specify it at all; - if upstream and local differ, then we must specify both, even though FOO_LOCAL_SOURCE is in the format we default to. So, I prefer we keep FOO_UPSTREAM_SOURCE, to really emp[hasise that it is upstream that is doing weird things, not us. I'm still open for discussion on this, though. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'