[Buildroot] [PATCH v2 1/4] libfm-extra: new package

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Vicente Olivert Riera,

On Mon, 24 Nov 2014 10:10:50 +0000, Vicente Olivert Riera wrote:

> On 11/22/2014 06:39 PM, Thomas Petazzoni wrote:
> > Dear Vicente Olivert Riera,
> > 
> > On Fri, 21 Nov 2014 15:33:07 +0000, Vicente Olivert Riera wrote:
> > 
> >> +LIBFM_EXTRA_VERSION = 1.2.3
> >> +LIBFM_EXTRA_SOURCE = libfm-$(LIBFM_EXTRA_VERSION).tar.xz
> > 
> > This is the exact same tarball as the one used for the libfm package:
> > 
> > +LIBFM_VERSION = 1.2.3
> > +LIBFM_SOURCE = libfm-$(LIBFM_VERSION).tar.xz
> > +LIBFM_SITE = http://sourceforge.net/projects/pcmanfm/files
> > 
> > Why do we have two different packages? Is it because libfm full version
> > needs menu-cache, and menu-cache needs libfm-extra?
> 
> Yes, that is exactly the reason. Look for instance how is done in
> LinuxFromScratch:
> 
> http://www.linuxfromscratch.org/blfs/view/svn/lxde/libfm-extra.html
> 
> They build libfm-extra first, then menu-cache and then libfm. I did
> exactly the same.

And you didn't explain that anywhere in the commit logs? No comments
about this in the code? If you want such non-obvious stuff to be merged
one day, you should at least add a little bit of explanation about it.

This all seems a bit crazy. How are the pcmanfm people building their
stuff?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com