Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 7/9] gpu-viv-bin-mx6q: Use self-extractible helper
Date: Thu, 27 Nov 2014 20:22:03 +0100	[thread overview]
Message-ID: <20141127192203.GL3900@free.fr> (raw)
In-Reply-To: <1416432642-26005-8-git-send-email-jezz@sysmic.org>

J?r?me, All,

On 2014-11-19 22:30 +0100, J?r?me Pouiller spake thusly:
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>

Ditto the variable re-ordering...

Reported-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  .../gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk           | 22 +++++-----------------
>  1 file changed, 5 insertions(+), 17 deletions(-)
> 
> diff --git a/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk b/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
> index 85d01d2..1e731b3 100644
> --- a/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
> +++ b/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
> @@ -12,29 +12,17 @@ GPU_VIV_BIN_MX6Q_VERSION = $(GPU_VIV_BIN_MX6Q_BASE_VERSION)-sfp
>  endif
>  GPU_VIV_BIN_MX6Q_SITE = $(FREESCALE_IMX_SITE)
>  GPU_VIV_BIN_MX6Q_SOURCE = gpu-viv-bin-mx6q-$(GPU_VIV_BIN_MX6Q_VERSION).bin
> -
>  GPU_VIV_BIN_MX6Q_INSTALL_STAGING = YES
> +GPU_VIV_BIN_MX6Q_PROVIDES = libegl libgles libopenvg
> +GPU_VIV_BIN_MX6Q_LIB_TARGET = $(call qstrip,$(BR2_PACKAGE_GPU_VIV_BIN_MX6Q_OUTPUT))
>  
> +# See freescale-imx.mk
>  GPU_VIV_BIN_MX6Q_LICENSE = Freescale Semiconductor Software License Agreement
> -
> -# No license file is included in the archive; we could extract it from
> -# the self-extractor, but that's just too much effort.
> -# This is a legal minefield: the EULA specifies that
> -# the Board Support Package includes software and hardware (sic!)
> -# for which a separate license is needed...
> +GPU_VIV_BIN_MX6Q_LICENSE_FILES = EULA
>  GPU_VIV_BIN_MX6Q_REDISTRIBUTE = NO
>  
> -GPU_VIV_BIN_MX6Q_PROVIDES = libegl libgles libopenvg
> -GPU_VIV_BIN_MX6Q_LIB_TARGET = $(call qstrip,$(BR2_PACKAGE_GPU_VIV_BIN_MX6Q_OUTPUT))
> -
> -# The archive is a shell-self-extractor of a bzipped tar. It happens
> -# to extract in the correct directory (gpu-viv-bin-mx6q-x.y.z)
> -# The --force makes sure it doesn't fail if the source dir already exists.
> -# The --auto-accept skips the license check - not needed for us
> -# because we have legal-info.
>  define GPU_VIV_BIN_MX6Q_EXTRACT_CMDS
> -	(cd $(BUILD_DIR); \
> -		sh $(DL_DIR)/$(GPU_VIV_BIN_MX6Q_SOURCE) --force --auto-accept)
> +	$(call FREESCALE_IMX_EXTRACT_HELPER,$(DL_DIR)/$(GPU_VIV_BIN_MX6Q_SOURCE))
>  endef
>  
>  # Instead of building, we fix up the inconsistencies that exist
> -- 
> 1.9.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-11-27 19:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19 21:30 [Buildroot] [PATCH v2 0/9] Better handling of freescale self-extractible binaries Jérôme Pouiller
2014-11-19 21:30 ` [Buildroot] [PATCH v2 1/9] freescale-imx: Add helper to extract " Jérôme Pouiller
2014-11-27 18:13   ` Yann E. MORIN
2014-11-19 21:30 ` [Buildroot] [PATCH v2 2/9] firmware-imx: Use self-extractible helper Jérôme Pouiller
2014-11-27 18:15   ` Yann E. MORIN
2014-11-19 21:30 ` [Buildroot] [PATCH v2 3/9] imx-vpu: " Jérôme Pouiller
2014-11-27 18:16   ` Yann E. MORIN
2014-11-19 21:30 ` [Buildroot] [PATCH v2 4/9] libfslcodec: " Jérôme Pouiller
2014-11-27 18:18   ` Yann E. MORIN
2014-11-19 21:30 ` [Buildroot] [PATCH v2 5/9] libfslparser: " Jérôme Pouiller
2014-11-27 18:19   ` Yann E. MORIN
2014-11-19 21:30 ` [Buildroot] [PATCH v2 6/9] libfslvpuwrap: " Jérôme Pouiller
2014-11-27 18:20   ` Yann E. MORIN
2014-11-19 21:30 ` [Buildroot] [PATCH v2 7/9] gpu-viv-bin-mx6q: " Jérôme Pouiller
2014-11-27 19:22   ` Yann E. MORIN [this message]
2014-11-19 21:30 ` [Buildroot] [PATCH v2 8/9] libz160: " Jérôme Pouiller
2014-11-19 21:30 ` [Buildroot] [PATCH v2 9/9] gpu-amd-bin-mx51: " Jérôme Pouiller
2014-11-27 21:29 ` [Buildroot] [PATCH v2 0/9] Better handling of freescale self-extractible binaries Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141127192203.GL3900@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox