From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] btrfs-progs: fix static build
Date: Fri, 28 Nov 2014 22:41:17 +0100 [thread overview]
Message-ID: <20141128224117.7a3f2f95@free-electrons.com> (raw)
In-Reply-To: <2de1279dcd485fe0a9dda147272221766bb7e187.1417159092.git.baruch@tkos.co.il>
Dear Baruch Siach,
On Fri, 28 Nov 2014 09:18:12 +0200, Baruch Siach wrote:
> diff --git a/package/btrfs-progs/btrfs-progs.mk b/package/btrfs-progs/btrfs-progs.mk
> index d16fa0d9aa6f..7122df1b0e76 100644
> --- a/package/btrfs-progs/btrfs-progs.mk
> +++ b/package/btrfs-progs/btrfs-progs.mk
> @@ -17,6 +17,10 @@ BTRFS_PROGS_LICENSE_FILES = COPYING
> ifeq ($(BR2_PREFER_STATIC_LIB),y)
> BTRFS_PROGS_MAKE_TARGET = static
> BTRFS_PROGS_MAKE_INSTALL_TARGET = install-static
> +ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
> +# Add -lintl for libuuid
> +BTRFS_PROGS_MAKE_FLAGS += lib_LIBS="-luuid -lblkid -lm -lz -llzo2 -L. -lintl"
> +endif
This is really ugly and not maintainable, we are doing this all over
the place to solve static linking issues, and it's going to be a
never-ending story. If the package doesn't use pkg-config, can't we at
least use it here, like:
lib_LIBS="$(shell pkg-config ...)"
?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-11-28 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 7:18 [Buildroot] [PATCH] btrfs-progs: fix static build Baruch Siach
2014-11-28 8:01 ` Peter Korsgaard
2014-11-28 21:41 ` Thomas Petazzoni [this message]
2014-11-29 19:00 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128224117.7a3f2f95@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox