From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/parted: fix static link
Date: Sat, 29 Nov 2014 19:14:17 +0100 [thread overview]
Message-ID: <20141129181417.GB4217@free.fr> (raw)
In-Reply-To: <87fvd2j67f.fsf@dell.be.48ers.dk>
Peter, All,
On 2014-11-29 17:56 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>
> > libuuid needs to be linked with -lintl when gettext is needed (with
> > locales).
>
> > For a static build, this is solved with the DT_NEEDED ELF tags, but for
>
> s/static/shared/
Yup, onviously. Fixed, thanks.
> > a static link, it is not pulled in automatically.
>
> > Use pkg-config to find libuuid, instead of AC_CHECK_LIB().
>
> > Second part at fixing:
> > http://autobuild.buildroot.net/results/c46/c467aeec258909bb82eda77123803944f97d8df8/
>
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > ---
> > .../parted/parted-003-fix-static-link-uuid.patch | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> > create mode 100644 package/parted/parted-003-fix-static-link-uuid.patch
>
> > diff --git a/package/parted/parted-003-fix-static-link-uuid.patch b/package/parted/parted-003-fix-static-link-uuid.patch
> > new file mode 100644
> > index 0000000..e281b6f
> > --- /dev/null
> > +++ b/package/parted/parted-003-fix-static-link-uuid.patch
> > @@ -0,0 +1,21 @@
>
> You forgot the patch description + signed-off-by.
Damn, I knew something was amiss in that submission.
If all that is incorrect is the patch description and a missing SoB,
then that's cool. I was expecting that series to be more controversial.
I'll respin those two a bit later. Thanks! :-)
> Otherwise it looks good. Please don't forget to send it upstream.
Yep, I'm actively pushing things upstream when it makes sense. ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2014-11-29 18:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-29 15:59 [Buildroot] [PATCH 0/2] parted: fix static link (branch yem/for-release) Yann E. MORIN
2014-11-29 15:59 ` [Buildroot] [PATCH 1/2] package/util-linux: libuuid needs -lintl Yann E. MORIN
2014-11-29 18:04 ` Baruch Siach
2014-11-29 18:12 ` Yann E. MORIN
2014-11-30 11:57 ` Yann E. MORIN
2014-11-29 15:59 ` [Buildroot] [PATCH 2/2] package/parted: fix static link Yann E. MORIN
2014-11-29 16:56 ` Peter Korsgaard
2014-11-29 18:14 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141129181417.GB4217@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox