Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/mono: fixing wrong monolite library path
Date: Sun, 30 Nov 2014 23:41:13 +0100	[thread overview]
Message-ID: <20141130224113.GE4124@free.fr> (raw)
In-Reply-To: <1417383666-23165-1-git-send-email-angelo.compagnucci@gmail.com>

Angelo, Rainer, All,

On 2014-11-30 22:41 +0100, Angelo Compagnucci spake thusly:
> Due to a bug in makefile logic, monolite libraries path will not
> be selected when EXTERNAL_MCS parameter is specified.
> Setting EXTERNAL_MCS to a non existent binary, makes the internal logic
> to fallback to monolite, setting correctly both binary and
> library paths.
> This has the benefit to force host-mono to always use monolite as
> bootstrap compiler also in case a mono compiler is already installed
> on the system.
> 
> Fixes:
> http://autobuild.buildroot.net/results/fc00952bef03cf3b4785be1a0d9c08dc84aa3f54/
> 
> 

Angelo, it is customary to add a reported-by tag to credit the person
that reported a bug. It's done like so:

Reported-by: Rainer Berns <rainer.berns@berns-online.de>

It is also customary to put the reporter in Cc: so he gets a proposed
fix and gets to test it.

Rainer, care to test this patch, please? If it works, can you reply to
this mail and add your tested-by tag?

It's done like so: Tested-by Your NAME <you@there>

Thank you both! :-)

/me is feeling like being educative tonight. Hihi! ;-)

Regards,
Yann E. MORIN.

> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> ---
>  package/mono/mono.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/mono/mono.mk b/package/mono/mono.mk
> index df67c33..d4beb5f 100644
> --- a/package/mono/mono.mk
> +++ b/package/mono/mono.mk
> @@ -55,7 +55,7 @@ HOST_MONO_CONF_OPTS += \
>  	--with-profile4=$(if $(BR2_PACKAGE_MONO_40),yes,no) \
>  	--with-profile4_5=$(if $(BR2_PACKAGE_MONO_45),yes,no)
>  
> -HOST_MONO_MAKE_OPTS += EXTERNAL_MCS="$(@D)/mcs/class/lib/monolite/basic.exe"
> +HOST_MONO_MAKE_OPTS += EXTERNAL_MCS=false 
>  
>  HOST_MONO_DEPENDENCIES = host-monolite host-gettext
>  
> -- 
> 2.2.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-11-30 22:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-30 21:41 [Buildroot] [PATCH] package/mono: fixing wrong monolite library path Angelo Compagnucci
2014-11-30 22:41 ` Yann E. MORIN [this message]
2014-11-30 22:52 ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2014-12-01 19:50 Rainer Berns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141130224113.GE4124@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox