Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] pkg-download: verify the hashes from the download wrapper
Date: Tue, 2 Dec 2014 09:29:04 +0100	[thread overview]
Message-ID: <20141202092904.7b6ce375@free-electrons.com> (raw)
In-Reply-To: <eb25ccfd009955fcd6be60822a8c22985aca199d.1417475935.git.yann.morin.1998@free.fr>

Dear Yann E. MORIN,

On Tue,  2 Dec 2014 00:24:08 +0100, Yann E. MORIN wrote:
> Instead of repeating the check in our download rules, delegate the check
> of the hashes to the download wrapper.
> 
> This needs three different changes:
> 
>   - add a new argument to the download wrapper, that is the full path to
>     the hash file; if the hash file does not exist, that does not change
>     the current behaviour, as the existence of the hash file is done by
>     the check-hash script;

It is really time to use getopt in the download wrapper scripts, as we
have discussed with Fabio recently regarding the fully silent build
thing.

>   - add a third argument to the check-hash script, to be the basename of
>     the file to check; this is required because we no longer check the
>     final file with the finale filename, but anintermediate file with a

finale -> final

anintermediate -> an intermediate

>     temporary filename;
> 
>   - do the actual cal to the check-hash script form within the download

cal?

form -> from.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-12-02  8:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01 23:24 [Buildroot] [PATCH 0/4] pkg-download: check hashes before the download (branch yem/download-hash) Yann E. MORIN
2014-12-01 23:24 ` [Buildroot] [PATCH 1/4] pkg-download: check for already downloaded file in the download wrapper Yann E. MORIN
2014-12-02  8:26   ` Thomas Petazzoni
2014-12-03 18:43     ` Yann E. MORIN
2014-12-01 23:24 ` [Buildroot] [PATCH 2/4] pkg-download: fix arguments to hash checking script Yann E. MORIN
2014-12-01 23:24 ` [Buildroot] [PATCH 3/4] pkg-download: verify the hashes from the download wrapper Yann E. MORIN
2014-12-02  8:29   ` Thomas Petazzoni [this message]
2014-12-03 18:45     ` Yann E. MORIN
2014-12-01 23:24 ` [Buildroot] [PATCH 4/4] pkg-download: check hasahes for locally cached files Yann E. MORIN
2014-12-02  8:31   ` Thomas Petazzoni
2014-12-02  9:27     ` Peter Korsgaard
2014-12-02  9:30       ` Thomas Petazzoni
2014-12-03 18:51     ` Yann E. MORIN
2014-12-06 12:44       ` Yann E. MORIN
2014-12-06 12:53         ` Thomas Petazzoni
2014-12-07 10:47           ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141202092904.7b6ce375@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox