From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] Makefile: improve detection of make "-s" flag
Date: Wed, 3 Dec 2014 19:17:01 +0100 [thread overview]
Message-ID: <20141203181701.GA4152@free.fr> (raw)
In-Reply-To: <1416419494-14916-1-git-send-email-fabio.porcedda@gmail.com>
Fabio, All,
On 2014-11-19 18:51 +0100, Fabio Porcedda spake thusly:
> Because it's just checked the presence of the "s" character even a
> make --warn-undefined-variables
> is detected as a silent build so fix this by filtering out long options.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> ---
>
> Notes:
> v4:
> - split this patch from the patch set to send to muster as bugfix
> v2:
> - remove spurious space at the beginning of the QUIET variable (Arnout)
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 471edf9..6b97dc6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -303,7 +303,7 @@ GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
> TARGETS :=
>
> # silent mode requested?
> -QUIET := $(if $(findstring s,$(MAKEFLAGS)),-q)
> +QUIET := $(if $(findstring s, $(filter-out --%, $(MAKEFLAGS))),-q)
Please, do not add a space after the comma when calling a macro. This
should be:
QUIET := $(if $(findstring s,$(filter-out --%,$(MAKEFLAGS))),-q)
Yes, that's slightly less readable. But make really cuts on commas, and
the sapce is then part of the values, so we do not want it (it has no
impact in your case, though, but: consistency! ;-) )
Otherwise, looks good to me.
Regards,
Yann E. MORIN.
>
> # Strip off the annoying quoting
> ARCH := $(call qstrip,$(BR2_ARCH))
> --
> 2.1.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-12-03 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 17:51 [Buildroot] [PATCH v4] Makefile: improve detection of make "-s" flag Fabio Porcedda
2014-11-28 13:10 ` Fabio Porcedda
2014-12-03 18:17 ` Yann E. MORIN [this message]
2014-12-09 17:48 ` Fabio Porcedda
2014-12-23 8:58 ` Fabio Porcedda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203181701.GA4152@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox