From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/nginx: disallow AIO support on arc
Date: Sun, 7 Dec 2014 21:24:29 +0100 [thread overview]
Message-ID: <20141207202429.GB3902@free.fr> (raw)
In-Reply-To: <1417871738-13421-1-git-send-email-s.martin49@gmail.com>
Samuel, All,
On 2014-12-06 14:15 +0100, Samuel Martin spake thusly:
> The nginx AIO support cannot build on arc, because it hardcodes
> the usage of SYS_eventfd(), while it should just use eventfd() from
> the C library.
>
> Fixes:
> http://autobuild.buildroot.org/results/f3e/f3e2c7a937517a5444f8c6cc0b02692af897b3e0/
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> package/nginx/Config.in | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/nginx/Config.in b/package/nginx/Config.in
> index c2a6af1..5b5c0b0 100644
> --- a/package/nginx/Config.in
> +++ b/package/nginx/Config.in
> @@ -17,9 +17,10 @@ if BR2_PACKAGE_NGINX
> config BR2_PACKAGE_NGINX_FILE_AIO
> bool "file AIO support"
> # Does not build, because nginx hardcodes using SYS_eventfd,
> - # but it's not available on AArch64, only eventfd() is.
> + # but it's not available on AArch64, nor arc only eventfd() is.
but it's available on neither AArch64 nor arc, where only eventfd() is.
Otherwise, looks good:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> # See https://bugs.launchpad.net/linaro-aarch64/+bug/1160013
> depends on !BR2_aarch64
> + depends on !BR2_arc
>
> config BR2_PACKAGE_NGINX_HTTP
> bool "http server"
> --
> 2.1.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-12-07 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 13:15 [Buildroot] [PATCH 1/2] package/nginx: disallow AIO support on arc Samuel Martin
2014-12-06 13:15 ` [Buildroot] [PATCH 2/2] package/libnss: need dynamic library support Samuel Martin
2014-12-06 15:19 ` Thomas Petazzoni
2014-12-06 15:24 ` Samuel Martin
2014-12-07 20:24 ` Yann E. MORIN [this message]
2014-12-07 20:28 ` [Buildroot] [PATCH 1/2] package/nginx: disallow AIO support on arc Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141207202429.GB3902@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox