Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/minidlna: fix static linking
Date: Sun, 7 Dec 2014 22:12:44 +0100	[thread overview]
Message-ID: <20141207211244.GD10809@free.fr> (raw)
In-Reply-To: <1417289621-17415-1-git-send-email-bernd.kuhls@t-online.de>

Bernd, All,

On 2014-11-29 20:33 +0100, Bernd Kuhls spake thusly:
> Fixes
> http://autobuild.buildroot.net/results/6bd/6bd8c009056beb67092abd6d18064500302dcecb/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> This patch depends on http://patchwork.ozlabs.org/patch/416006/
> 
>  package/minidlna/minidlna.mk |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/minidlna/minidlna.mk b/package/minidlna/minidlna.mk
> index 3a0ca35..d483e1c 100644
> --- a/package/minidlna/minidlna.mk
> +++ b/package/minidlna/minidlna.mk
> @@ -18,8 +18,10 @@ ifeq ($(BR2_PREFER_STATIC_LIB),y)
>  # the configure script / Makefile forgets to link with some of the dependent
>  # libraries breaking static linking, so help it along
>  MINIDLNA_CONF_ENV = \
> -	LIBS='-lavformat -lavcodec -lavutil -logg \
> +	LIBS='-lavformat -lavcodec -lavutil -logg -lvorbis -lvorbisenc \
> +		$(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),-lintl) -lexif \
>  		$(if $(BR2_PACKAGE_OPENSSL),-lssl -lcrypto) \
> +		$(if $(BR2_PACKAGE_OPUS),-lswresample -lopus) \

Ofd course, this should be adapted with the previous comment to your
previous patch.

But hold on on it, I'd like Thomas P. to ack my comment before you work
on it...

Regards,
Yann E. MORIN.

>  		-lz -lpthread -lm'
>  else
>  MINIDLNA_CONF_OPTS = \
> -- 
> 1.7.10.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2014-12-07 21:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-29 19:33 [Buildroot] [PATCH 1/1] package/minidlna: fix static linking Bernd Kuhls
2014-12-07 21:12 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141207211244.GD10809@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox