Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/3] libz160: fix dependencies
Date: Sun, 7 Dec 2014 22:41:22 +0100	[thread overview]
Message-ID: <20141207214121.GE10809@free.fr> (raw)
In-Reply-To: <1417252360-10929-3-git-send-email-jezz@sysmic.org>

J?r?me, All,

On 2014-11-29 10:12 +0100, J?r?me Pouiller spake thusly:
> libz160 is provided as binary. We need EABI toolchain with glibc to use
> it.
> 
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> ---
>  package/freescale-imx/libz160/Config.in | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/freescale-imx/libz160/Config.in b/package/freescale-imx/libz160/Config.in
> index f956cce..f4abcc5 100644
> --- a/package/freescale-imx/libz160/Config.in
> +++ b/package/freescale-imx/libz160/Config.in
> @@ -1,5 +1,11 @@
>  config BR2_PACKAGE_LIBZ160
>  	bool "libz160"
> +	depends on BR2_ARM_EABI
> +	depends on BR2_TOOLCHAIN_USES_GLIBC
>  	help
>  	  An API for user space programs to perform 2D accelerated graphics
>  	  operations on AMD GPU (included for examples in iMX5x chipsets)
> +
> +comment "libz160 needs an EABI toolchain w/ (e)glibc"
> +	depends on BR2_arm

Not needed, we're already in a depends-on-arm block thanks to
BR2_PACKAGE_FREESCALE_IMX.

> +	depends on (!BR2_ARM_EABI || !BR2_TOOLCHAIN_USES_GLIBC)

The parenthesis are superfluous here.

Otherwise:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> -- 
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-12-07 21:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-29  9:12 [Buildroot] [PATCH v2 0/3] Add support for iMX5 GPU Jérôme Pouiller
2014-11-29  9:12 ` [Buildroot] [PATCH v2 1/3] gpu-amd-bin-mx51: new package Jérôme Pouiller
2015-01-14 22:06   ` Thomas Petazzoni
2014-11-29  9:12 ` [Buildroot] [PATCH v2 2/3] libz160: fix dependencies Jérôme Pouiller
2014-12-07 21:41   ` Yann E. MORIN [this message]
2014-12-07 21:48   ` Thomas Petazzoni
2014-11-29  9:12 ` [Buildroot] [PATCH v2 3/3] xdriver_xf86-video-imx: new package Jérôme Pouiller
2015-04-26 10:22   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141207214121.GE10809@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox