Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5 v2] pkg-download: verify the hashes from the download wrapper
Date: Mon, 8 Dec 2014 00:10:40 +0100	[thread overview]
Message-ID: <20141207231040.GM10809@free.fr> (raw)
In-Reply-To: <70023398f1201f12b64802bdc16fd0711dc97050.1417949583.git.yann.morin.1998@free.fr>

All,

On 2014-12-07 12:02 +0100, Yann E. MORIN spake thusly:
> Instead of repeating the check in our download rules, delegate the check
> of the hashes to the download wrapper.
[--SNIP--]
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> index 9192950..b3ddfe3 100644
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
[--SNIP--]
> @@ -174,9 +167,9 @@ endef
>  define DOWNLOAD_SCP
>  	$(EXTRA_ENV) $(DL_WRAPPER) -b scp \
>  		-o $(DL_DIR)/$(2) \
> +		-H $(PKGDIR)/$($(PKG)_NAME).hash \
>  		-- \
>  		'$(call stripurischeme,$(call qstrip,$(1)))' && \

Damn, left-over bug... :-( Uncommitted file. Forgot git add... :-(

Marking this series as "Changes requested", because we suddenly
uncovered another hash-related bug (especially without that series),
which happens for host packages for which the tarball is broken: hashes
are not checked for host packages...

I'll investigate that problem before I respin the series...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-12-07 23:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-07 11:02 [Buildroot] [PATCH 0/5 v2] pkg-download: check hashes before the download (branch yem/download-hash) Yann E. MORIN
2014-12-07 11:02 ` [Buildroot] [PATCH 1/5 v2] pkg-download: fix arguments to hash checking script Yann E. MORIN
2014-12-07 21:08   ` Thomas Petazzoni
2014-12-07 11:02 ` [Buildroot] [PATCH 2/5 v2] suppot/download: add option parsing to the download wrapper Yann E. MORIN
2014-12-07 12:04   ` Thomas Petazzoni
2014-12-07 11:02 ` [Buildroot] [PATCH 3/5 v2] pkg-download: check for already downloaded file in " Yann E. MORIN
2014-12-07 11:02 ` [Buildroot] [PATCH 4/5 v2] pkg-download: verify the hashes from " Yann E. MORIN
2014-12-07 23:10   ` Yann E. MORIN [this message]
2014-12-07 23:39     ` Yann E. MORIN
2014-12-07 11:02 ` [Buildroot] [PATCH 5/5 v2] pkg-download: check hashes for locally cached files Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141207231040.GM10809@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox