Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] pkg-download: VERIFY_HASH: use same hash file for host and target downloads
Date: Mon, 8 Dec 2014 19:00:24 +0100	[thread overview]
Message-ID: <20141208180024.GD4105@free.fr> (raw)
In-Reply-To: <20141208075330.0542F80144@busybox.osuosl.org>

Peter, All,

On 2014-12-08 08:52 +0100, Peter Korsgaard spake thusly:
> commit: http://git.buildroot.net/buildroot/commit/?id=cf902845e7c23da7acddd82dc591255e4657d730
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> 
> Fixes (or atleast stops the build with a saner description):
> http://autobuild.buildroot.net/results/1a9/1a9643f8633db038d4fe5ca4a32e4d52e70a3a1a/
> 
> We're using the same sources for host and target downloads, so it makes
> sense to use the same <pkg>.hash file as well to ensure the host version
> gets verified without us having to maintain a seperate host-<pkg>.hash file.

Damn, I had this in my download-hash series:
    http://lists.busybox.net/pipermail/buildroot/2014-December/114493.html

I'll have to rebase it now... Hehe! ;-p

Regards,
Yann E. MORIN.

> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/pkg-download.mk |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> index f3409bd..190b5b7 100644
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
> @@ -174,7 +174,7 @@ define DOWNLOAD_SCP
>  	$(EXTRA_ENV) support/download/wrapper scp \
>  		$(DL_DIR)/$(2) \
>  		'$(call stripurischeme,$(call qstrip,$(1)))' && \
> -	$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_NAME).hash,$(DL_DIR)/$(2))
> +	$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_RAWNAME).hash,$(DL_DIR)/$(2))
>  endef
>  
>  define SOURCE_CHECK_SCP
> @@ -211,7 +211,7 @@ define DOWNLOAD_WGET
>  	$(EXTRA_ENV) support/download/wrapper wget \
>  		$(DL_DIR)/$(2) \
>  		'$(call qstrip,$(1))' && \
> -	$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_NAME).hash,$(DL_DIR)/$(2))
> +	$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_RAWNAME).hash,$(DL_DIR)/$(2))
>  endef
>  
>  define SOURCE_CHECK_WGET
> @@ -227,7 +227,7 @@ define DOWNLOAD_LOCALFILES
>  	$(EXTRA_ENV) support/download/wrapper cp \
>  		$(DL_DIR)/$(2) \
>  		$(call stripurischeme,$(call qstrip,$(1))) && \
> -	$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_NAME).hash,$(DL_DIR)/$(2))
> +	$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_RAWNAME).hash,$(DL_DIR)/$(2))
>  endef
>  
>  define SOURCE_CHECK_LOCALFILES
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-12-08 18:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08  7:52 [Buildroot] [git commit] pkg-download: VERIFY_HASH: use same hash file for host and target downloads Peter Korsgaard
2014-12-08 18:00 ` Yann E. MORIN [this message]
2014-12-08 20:00   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141208180024.GD4105@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox