Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ltrace: disable elfutils unwinding when libunwind is used
Date: Tue, 9 Dec 2014 08:51:34 +0100	[thread overview]
Message-ID: <20141209085134.1b2051b9@free-electrons.com> (raw)
In-Reply-To: <20141209060247.GJ2440@tarshish>

Dear Baruch Siach,

On Tue, 9 Dec 2014 08:02:47 +0200, Baruch Siach wrote:

> > While I agree with the analysis, I don't agree with the proposed fix:
> > ltrace selects elfutils unconditionally (see Config.in), so it is quite
> > weird to see ltrace not using it in the end. So I believe the Config.in
> > *and* ltrace dependencies should be updated to reflect the fact that
> > either unwind or elfutils can be used.
> 
> It turns out that --with-elfutils=no is a misnomer. ltrace depends on libelf 
> regardless of --with-elfutils, so we must have elfutils both in Config.in and 
> in LTRACE_DEPENDENCIES. The only effect of --with-elfutils is on unwinding 
> back-end. Quoting configure.ac:
> 
>   AS_HELP_STRING([--with-elfutils], [Use elfutils libdwfl unwinding support]),
> 
> I'll send a revised version of this patch with a better commit log, and a 
> comment in the code explaining this weirdness.

Aah, ok. Indeed very confusing. Thanks for clarifying this and posting
an updated version with more details!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2014-12-09  7:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05  7:09 [Buildroot] [PATCH] ltrace: disable elfutils unwinding when libunwind is used Baruch Siach
2014-12-07 21:00 ` Thomas Petazzoni
2014-12-09  6:02   ` Baruch Siach
2014-12-09  7:51     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141209085134.1b2051b9@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox