Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/6] package/mpd: enable neighbor discovery support
Date: Tue, 9 Dec 2014 20:15:08 +0100	[thread overview]
Message-ID: <20141209201508.0168241a@free-electrons.com> (raw)
In-Reply-To: <1418078694-26331-5-git-send-email-jkrause@posteo.de>

Dear J?rg Krause,

On Mon,  8 Dec 2014 23:44:53 +0100, J?rg Krause wrote:
> Enable support for neighbor discovery useful in Samba and UPnP networks.
> 
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
> ---
>  package/mpd/Config.in | 10 ++++++++++
>  package/mpd/mpd.mk    |  6 ++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/package/mpd/Config.in b/package/mpd/Config.in
> index 901902b..57ed434 100644
> --- a/package/mpd/Config.in
> +++ b/package/mpd/Config.in
> @@ -269,6 +269,16 @@ config BR2_PACKAGE_MPD_AVAHI_SUPPORT
>  comment "avahi support needs a toolchain w/ dynamic library"
>  	depends on BR2_PREFER_STATIC_LIB
>  
> +config BR2_PACKAGE_MPD_NEIGHBOR_DISCOVERY_SUPPORT
> +	bool "neighbor discovery support"
> +	help
> +	  Enable support for neighbor discovery.
> +	  This option may be used in conjunction with the plugin samba to
> +	  provide a list of SMB/CIFS servers or with the plugin UPnP to provide
> +	  a list of UPnP servers on the local network.
> +	  The neighbor plugin needs configuration in mpd.conf. For further
> +	  information take a look at the MPD documentation.

After looking a bit at the MPD configure.ac script and Makefile.am, it
appeared to me that this feature doesn't do anything useful if there
isn't either smbclient or upnp support enabled, so I made this option
depends on smbclient or upnp support.

Applied with this change, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-12-09 19:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 22:44 [Buildroot] [PATCH 1/6] package/mpd: bump to version 0.19.6 Jörg Krause
2014-12-08 22:44 ` [Buildroot] [PATCH 2/6] package/mpd: fix typo Jörg Krause
2014-12-09 18:53   ` Thomas Petazzoni
2014-12-08 22:44 ` [Buildroot] [PATCH 3/6] package/mpd: make all package names in help text uppercase Jörg Krause
2014-12-09 18:54   ` Thomas Petazzoni
2014-12-08 22:44 ` [Buildroot] [PATCH 4/6] package/mpd: fix line length for help text Jörg Krause
2014-12-09 18:54   ` Thomas Petazzoni
2014-12-08 22:44 ` [Buildroot] [PATCH 5/6] package/mpd: enable neighbor discovery support Jörg Krause
2014-12-09 19:15   ` Thomas Petazzoni [this message]
2014-12-08 22:44 ` [Buildroot] [PATCH 6/6] package/mpd: enable OSS support Jörg Krause
2014-12-09 19:16   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141209201508.0168241a@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox