From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libsvgtiny: disable -Werror
Date: Wed, 10 Dec 2014 17:00:22 +0100 [thread overview]
Message-ID: <20141210170022.1cc25505@free-electrons.com> (raw)
In-Reply-To: <1418223572-2456-1-git-send-email-Vincent.Riera@imgtec.com>
Dear Vicente Olivert Riera,
On Wed, 10 Dec 2014 14:59:32 +0000, Vicente Olivert Riera wrote:
> glibc-2.20 includes some changes to the include/features.h file
> introduced by this commit:
>
> https://sourceware.org/git/?p=glibc.git;a=commit;h=ade40b10ff5fa59a318cf55b9d8414b758e8df78
>
> Those changes make libsvgtiny fail because some warnings are thrown and
> the build system is using the -Werror option. We disable this to be able
> to build it, or otherwise we will see errors like this one:
>
> GPERF: src/colors.gperf
> COMPILE: build-Linux-Linux-release-lib-static/src_colors.c
> In file included from
> /br/output/host/usr/mipsel-buildroot-linux-gnu/sysroot/usr/include/string.h:25:0,
> from src/colors.gperf:16:
> /br/output/host/usr/mipsel-buildroot-linux-gnu/sysroot/usr/include/features.h:148:3:
> error: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use
> _DEFAULT_SOURCE" [-Werror=cpp]
>
> and this one:
>
> In file included from src/colors.gperf:18:0:
> /home/ldap/vriera/work/mips-buildroots/mips32/output/build/libsvgtiny-12121/src/svgtiny_internal.h:71:0:
> error: "strndup" redefined [-Werror]
>
> Fixes:
> http://autobuild.buildroot.net/results/3dd/3dd700405055750262738f867eb5aa08531f5781/
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
If you have some time, it would be good to report upstream that they
shouldn't use -Werror, and to fix the warnings themselves.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-12-10 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 14:59 [Buildroot] [PATCH] libsvgtiny: disable -Werror Vicente Olivert Riera
2014-12-10 16:00 ` Thomas Petazzoni [this message]
2014-12-10 20:40 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210170022.1cc25505@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox