Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ncurses: add support for 256 colors
Date: Thu, 11 Dec 2014 19:14:31 +0100	[thread overview]
Message-ID: <20141211181431.GA4199@free.fr> (raw)
In-Reply-To: <54870BA3.2010205@free.fr>

Thierry, All,

On 2014-12-09 15:48 +0100, Thierry Bultel spake thusly:
> Le 09/12/2014 13:21, Gustavo Zacarias a ?crit :
> >On 12/09/2014 07:58 AM, Thierry Bultel wrote:
> >
> >>+config BR2_PACKAGE_NCURSES_EXT_COLORS
> >>+	bool "ncurses extended colors"
> >>+	select BR2_PACKAGE_NCURSES_WCHAR
> >>+	depends on BR2_USE_WCHAR
> >>+	help
> >>+	  compile for 256-color support
> >>+
> >
> >Hi.
> >Do you know the size delta between this option enabled and disabled?
> >I'm asking because it might not be even worth an option.
> >Thanks.
> >Regards.
> >
> 
> Hi, the size delta is quite small:
> 
> 256 colors:
> 
> -rwxr-xr-x 1 thierry thierry 210K d?c.   9 14:23
> output/target/usr/lib/libncursesw.so.6.0
> 
> std colors:
> 
> -rwxr-xr-x 1 thierry thierry 202K d?c.   9 15:46
> output/target/usr/lib/libncursesw.so.5.9

Then, I'd say we just enable it by default, since the size delta is
negligible (~4%).

There is only one case that would require that to be an option: if it
changes the API, and packages that do not expect it would break.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-12-11 18:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09 10:58 [Buildroot] [PATCH 1/1] ncurses: add support for 256 colors Thierry Bultel
2014-12-09 12:21 ` Gustavo Zacarias
2014-12-09 14:48   ` Thierry Bultel
2014-12-11 18:14     ` Yann E. MORIN [this message]
2014-12-12 22:43       ` Thierry Bultel
2014-12-12 22:46         ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141211181431.GA4199@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox