Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] iprutils: Don't include host headers
Date: Fri, 12 Dec 2014 09:58:24 +0100	[thread overview]
Message-ID: <20141212095824.2c30720f@free-electrons.com> (raw)
In-Reply-To: <1418340467-29999-2-git-send-email-romain.naour@openwide.fr>

Dear Romain Naour,

On Fri, 12 Dec 2014 00:27:46 +0100, Romain Naour wrote:
> Fixes:
> ERROR: unsafe header/library path used in cross-compilation: '/usr/include/ncurses'
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/iprutils/iprutils.mk | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/package/iprutils/iprutils.mk b/package/iprutils/iprutils.mk
> index 53516b6..0721fbf 100644
> --- a/package/iprutils/iprutils.mk
> +++ b/package/iprutils/iprutils.mk
> @@ -12,11 +12,14 @@ IPRUTILS_LICENSE = Common Public License Version 1.0
>  IPRUTILS_LICENSE_FILES = LICENSE
>  
>  define IPRUTILS_BUILD_CMDS
> -	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) all
> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) \
> +		INCLUDEDIR="-I. -I$(STAGING_DIR)/usr/include/ncurses" \
> +		-C $(@D) all

Thanks. Shouldn't we instead patch the Makefile itself, and submit the
change upstream?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-12-12  8:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11 23:27 [Buildroot] [PATCH 1/3] iprutils: rename patches to follow the new name convention Romain Naour
2014-12-11 23:27 ` [Buildroot] [PATCH 2/3] iprutils: Don't include host headers Romain Naour
2014-12-12  8:58   ` Thomas Petazzoni [this message]
2014-12-12 23:28     ` Romain Naour
2014-12-11 23:27 ` [Buildroot] [PATCH 3/3] iprutils: bump to version 2.4.5 Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141212095824.2c30720f@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox