From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] blktrace: really fix parallel build issue
Date: Sun, 14 Dec 2014 22:44:14 +0100 [thread overview]
Message-ID: <20141214214414.GF4121@free.fr> (raw)
In-Reply-To: <20141214205926.B40ED7FDC7@busybox.osuosl.org>
Peter, All,
On 2014-12-14 21:56 +0100, Peter Korsgaard spake thusly:
> commit: http://git.buildroot.net/buildroot/commit/?id=6b706679b576502272b4d82a9e5b996630ea991c
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> Fixes:
> http://autobuild.buildroot.net/results/dd4/dd47b3ca17bdb597d6b12de6b381cf5f25abaf71/
> http://autobuild.buildroot.net/results/a84/a842234fbdc8f65d48089b90ee23523540a7091f/
> http://autobuild.buildroot.net/results/e63/e6351692ad6aef397e68ffdf107f3a85e4490015/
>
> And many more.
>
> Commit a21163aed (package/blktrace: do not build in parallel) tried to fix
> the parallel build issue, but the package doesn't use the autotools package
> infrastructure so BLKTRACE_MAKE isn't used. Instead replace the explicit
> $(MAKE) calls with $(MAKE1).
>
> Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> package/blktrace/blktrace.mk | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/package/blktrace/blktrace.mk b/package/blktrace/blktrace.mk
> index 8f3dbab..c193375 100644
> --- a/package/blktrace/blktrace.mk
> +++ b/package/blktrace/blktrace.mk
> @@ -10,14 +10,12 @@ BLKTRACE_DEPENDENCIES = libaio
> BLKTRACE_LICENSE = GPLv2+
> BLKTRACE_LICENSE_FILES = COPYING
>
> -BLKTRACE_MAKE = $(MAKE1)
> -
> define BLKTRACE_BUILD_CMDS
> - $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS)
> + $(MAKE1) -C $(@D) $(TARGET_CONFIGURE_OPTS)
Damn, I was not able to reproduce the error on my machine, so I assumed
it was working.
Thanks for fixing this...
Regards,
Yann E. MORIN.
> endef
>
> define BLKTRACE_INSTALL_TARGET_CMDS
> - $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) install \
> + $(MAKE1) -C $(@D) $(TARGET_CONFIGURE_OPTS) install \
> DESTDIR=$(TARGET_DIR) prefix=/usr
> endef
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2014-12-14 21:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 20:56 [Buildroot] [git commit] blktrace: really fix parallel build issue Peter Korsgaard
2014-12-14 21:44 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141214214414.GF4121@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox