Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Steve James <ste@junkomatic.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] snappy: add dependency on host-pkgconf
Date: Mon, 15 Dec 2014 13:44:14 +0000	[thread overview]
Message-ID: <201412151344.14441.ste@junkomatic.net> (raw)

Signed-off-by: Steve James <ste@junkomatic.net>

---
Hello all. First Buildroot patch :-)

(This was discovered when adding leveldb which requires snappy. This missing
dependency is exposed when selection of this package is the only non-default
configuration choice ie you're not getting host-pkgconf via some other non-
default choice.)

Snappy doesn't configure without host pkg-config. The diagnostic from autoconf
is totally unhelpful, so for the benefit of others who might need this
prerequisite, when autoconf says this...

  configure.ac:42: error: possibly undefined macro: AC_DEFINE
        If this token and others are legitimate, please use m4_pattern_allow.
        See the Autoconf documentation.
  configure.ac:44: error: possibly undefined macro: AC_MSG_FAILURE

The solution is (probably) to add host-pkgconf to the packages's DEPENDENCIES
list.


 package/snappy/snappy.mk |    1 +
 1 file changed, 1 insertion(+)

diff --git a/package/snappy/snappy.mk b/package/snappy/snappy.mk
index fd89325..6bda7ce 100644
--- a/package/snappy/snappy.mk
+++ b/package/snappy/snappy.mk
@@ -10,6 +10,7 @@ SNAPPY_LICENSE = BSD-3c
 SNAPPY_LICENSE_FILES = COPYING
 # from git
 SNAPPY_AUTORECONF = YES
+SNAPPY_DEPENDENCIES = host-pkgconf
 SNAPPY_INSTALL_STAGING = YES
 
 $(eval $(autotools-package))
-- 
1.7.10.4

             reply	other threads:[~2014-12-15 13:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-15 13:44 Steve James [this message]
2014-12-15 17:37 ` [Buildroot] [PATCH] snappy: add dependency on host-pkgconf Yann E. MORIN
2014-12-17 12:18   ` Steve James
2014-12-17 18:14     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201412151344.14441.ste@junkomatic.net \
    --to=ste@junkomatic.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox