Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/kismet: fix ncurses static build
Date: Fri, 26 Dec 2014 21:53:32 +0100	[thread overview]
Message-ID: <20141226205332.GG3982@free.fr> (raw)
In-Reply-To: <20141226210112.224245f6@free-electrons.com>

Thomas, All,

On 2014-12-26 21:01 +0100, Thomas Petazzoni spake thusly:
> On Fri, 26 Dec 2014 18:33:08 +0100, Yann E. MORIN wrote:
> 
> > diff --git a/package/kismet/0003-fix-curses-libs-ordering.patch b/package/kismet/0003-fix-curses-libs-ordering.patch
> > new file mode 100644
> > index 0000000..c5e7eff
> > --- /dev/null
> > +++ b/package/kismet/0003-fix-curses-libs-ordering.patch
> > @@ -0,0 +1,52 @@
> > +configure: fix ordering of ncurses libraries
> > +
> > +Says Vicente:
> > +    [T]he order is very important when doing static builds.
> > +    Otherwise we will see errors like this one:
> > +
> > +    [...]/sysroot/usr/lib/libpanel.a(p_delete.o):
> > +    In function `del_panel':
> > +    p_delete.c:(.text+0x68): undefined reference to `_nc_panelhook'
> > +
> > +Fix the order configure adds libraries: new libraries should be added
> > +at the *front* of the list, not at the end.
> 
> So this is only talking about library ordering.
> 
> > +-# Add additional cflags since some distros bury panel.h
> > +-CPPFLAGS="$CPPFLAGS -I/usr/include/ncurses"
> 
> But the patch also removes some invalid -I path.

Damn, that was supposed to go in a separate patch.

I'll fix. Thanks for spotting.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-12-26 20:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-26 17:33 [Buildroot] [PATCH 0/2] kismet: fix static builds (branch yem/fixes) Yann E. MORIN
2014-12-26 17:33 ` [Buildroot] [PATCH 1/2] package/kismet: fix ncurses static build Yann E. MORIN
2014-12-26 20:01   ` Thomas Petazzoni
2014-12-26 20:53     ` Yann E. MORIN [this message]
2014-12-26 17:33 ` [Buildroot] [PATCH 2/2] kismet: Fix " Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141226205332.GG3982@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox