From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/lftp: don't use host's path
Date: Sat, 27 Dec 2014 11:28:41 +0100 [thread overview]
Message-ID: <20141227112841.07a2db0b@free-electrons.com> (raw)
In-Reply-To: <549DD815.8080003@openwide.fr>
Dear Romain Naour,
On Fri, 26 Dec 2014 22:50:13 +0100, Romain Naour wrote:
> At first sight, one solution is to set $(DESTDIR) to $(STAGING_DIR)
>
> proto_ftp_la_LIBADD = -L$(DESTDIR)$(pkgverlibdir) liblftp-network.la
> proto_http_la_LIBADD = -L$(DESTDIR)$(pkgverlibdir) liblftp-network.la $(EXPAT_LIBS) $(ZLIB)
> proto_fish_la_LIBADD = -L$(DESTDIR)$(pkgverlibdir) liblftp-network.la liblftp-pty.la
> proto_sftp_la_LIBADD = -L$(DESTDIR)$(pkgverlibdir) liblftp-network.la liblftp-pty.la
> cmd_torrent_la_LIBADD = -L$(DESTDIR)$(pkgverlibdir) liblftp-network.la
>
> But I think we can remove -L$(DESTDIR)$(pkgverlibdir) since it doesn't seem to be useful.
> The build succeed (without paranoid toolchain) even with /usr/lib/lftp/4.5.5 or
> $(STAGING_DIR)/usr/lib/lftp/4.5.5 which both doesn't exist.
Yes, I think those -L are not needed: by the time it gets built/linked,
no libraries are installed in this location.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-12-27 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 17:29 [Buildroot] [PATCH 1/2] package/lftp: don't use host's path Romain Naour
2014-12-26 17:29 ` [Buildroot] [PATCH 2/2] package/tmux: remove unsafe headers path Romain Naour
2014-12-27 10:27 ` Thomas Petazzoni
2014-12-26 19:11 ` [Buildroot] [PATCH 1/2] package/lftp: don't use host's path Thomas Petazzoni
2014-12-26 21:50 ` Romain Naour
2014-12-27 10:28 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141227112841.07a2db0b@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox