Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 03/14] gpu-viv-bin-mx6q: fix compiling issues with EGL_API_FB
Date: Sat, 27 Dec 2014 20:13:58 +0100	[thread overview]
Message-ID: <20141227201358.01abe132@free-electrons.com> (raw)
In-Reply-To: <1417253726-14395-4-git-send-email-jezz@sysmic.org>

Dear J?r?me Pouiller,

On Sat, 29 Nov 2014 10:35:15 +0100, J?r?me Pouiller wrote:
> To compile with Vivante header and use framebuffer, it is necessary to
> pass option -DEGL_API_FB. This option is declared in pkg-config file of
> Vivante library. But many packages (especialy qt5 components) does not
> consider these flags.
> 
> So instead of patching every packages that use EGL, it is more
> convenient to patch Vivante headers.
> 
> This commit add #define EGL_API_FB on top of eglvivante.h when
> necessary.
> 
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> ---
>  package/freescale-imx/gpu-viv-bin-mx6q/egl.pc              |  2 +-
>  package/freescale-imx/gpu-viv-bin-mx6q/glesv2.pc           |  2 +-
>  package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk | 10 ++++++----
>  package/freescale-imx/gpu-viv-bin-mx6q/vg.pc               |  2 +-
>  4 files changed, 9 insertions(+), 7 deletions(-)

I am still uncertain about this one. Hardcoding the backend choice in
the header file seems really ugly, and using proper pkg-config files a
much better solution. Shouldn't we instead patch qt5 ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-12-27 19:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-29  9:35 [Buildroot] [PATCH v3 00/14] Add Xorg support for iMX6 Jérôme Pouiller
2014-11-29  9:35 ` [Buildroot] [PATCH v3 01/14] mesa3d: Give possibility to external backends to enable DRI/Gallium Jérôme Pouiller
2014-12-27 19:14   ` Thomas Petazzoni
2014-11-29  9:35 ` [Buildroot] [PATCH v3 02/14] gpu-viv-bin-mx6q: use self-extractible helper Jérôme Pouiller
2014-12-27 19:13   ` Thomas Petazzoni
2014-11-29  9:35 ` [Buildroot] [PATCH v3 03/14] gpu-viv-bin-mx6q: fix compiling issues with EGL_API_FB Jérôme Pouiller
2014-12-27 19:13   ` Thomas Petazzoni [this message]
2014-11-29  9:35 ` [Buildroot] [PATCH v3 04/14] gpu-viv-bin-mx6q: fix GLESv2 support Jérôme Pouiller
2014-11-29  9:35 ` [Buildroot] [PATCH v3 05/14] gpu-viv-bin-mx6q: make fb/x11 choice explicit Jérôme Pouiller
2014-11-29  9:35 ` [Buildroot] [PATCH v3 06/14] gpu-viv-bin-mx6q: change output selection mechanism Jérôme Pouiller
2014-11-29  9:35 ` [Buildroot] [PATCH v3 07/14] xdriver_xf86-video-imx-viv: new package Jérôme Pouiller
2014-11-29  9:35 ` [Buildroot] [PATCH v3 08/14] libdrm: fix support for xserver with Vivante drivers Jérôme Pouiller
2014-11-29  9:35 ` [Buildroot] [PATCH v3 09/14] qt5base: apply new patch naming policy Jérôme Pouiller
2014-11-29  9:35 ` [Buildroot] [PATCH v3 10/14] qt5base: fix Vivante x11/EGL configuration Jérôme Pouiller
2014-11-29  9:35 ` [Buildroot] [PATCH v3 11/14] Vivante drivers: bump to version 3.10.17-1.0.1 Jérôme Pouiller
2014-11-29  9:35 ` [Buildroot] [PATCH v3 12/14] nitrogen6x_defconfig: bump kernel to 3.10.17_1.0.1_ga Jérôme Pouiller
2014-11-29  9:35 ` [Buildroot] [PATCH v3 13/14] freescale_imx6*_defconfig: " Jérôme Pouiller
2014-11-29  9:35 ` [Buildroot] [PATCH v3 14/14] qmx6_defconfig: update Jérôme Pouiller
2014-12-02  3:05 ` [Buildroot] [PATCH v3 00/14] Add Xorg support for iMX6 Gary Bisson
2014-12-02  9:08   ` Jérôme Pouiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141227201358.01abe132@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox