From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 1/4] Rename the variable "QUIET" to "BR_QUIET" for conformance
Date: Sun, 28 Dec 2014 22:57:47 +0100 [thread overview]
Message-ID: <20141228215747.GA5434@free.fr> (raw)
In-Reply-To: <CAHkwnC9=VJYF+1+Soz3AETg-B7ZPw-6_08mjG99XOsyQs=WP8A@mail.gmail.com>
Fabio, All,
On 2014-12-28 17:24 +0100, Fabio Porcedda spake thusly:
> On Tue, Dec 23, 2014 at 11:51 AM, Fabio Porcedda
> <fabio.porcedda@gmail.com> wrote:
> > On Tue, Dec 23, 2014 at 11:17 AM, Thomas Petazzoni
> > <thomas.petazzoni@free-electrons.com> wrote:
> >> Hello,
> >>
> >> On Tue, 23 Dec 2014 09:54:58 +0100, Fabio Porcedda wrote:
> >>> Rename the variable "QUIET" to "BR_QUIET" accordingly to the convention
> >>> that internal variables should be named BR_XXX.
> >>>
> >>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> >>
> >> Do we really want all internal variables to be named BR_* ? Like
> >> HOST_CONFIGURE_OPTS, TARGET_CONFIGURE_OPTS, TARGET_MAKE_ENV and al. ?
> >> I'm not sure we want to do this, do we?
> >
> > On Wed, Nov 26, 2014 at 10:35 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > <snip>
> >> Also, in retrospect, QUIET was not a really good name for this variable
> >> in the Makefile. It would have been better if it were named BR_QUIET.
> >> But that was introduced way before we decided on a variable naming
> >> convention... :-/
> >
> > So which naming conventions Yann was referring?
>
> Hi Yann,
> Can you please explain further your opinion?
Oh, sorry, it seems I was not explicit enough in my mail...
What I said was "QUIET was not a really good name [...] that was
introduced way before we decided on a variable naming convention..."
I did not want to make it sound like we should rename it, sorry.
I agree with Thomas here: we should keep QUIET as-is.
Sorry, sorry for the confusion... :-(
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-12-28 21:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 8:54 [Buildroot] [PATCH v5 0/4] Improve silent builds Fabio Porcedda
2014-12-23 8:54 ` [Buildroot] [PATCH v5 1/4] Rename the variable "QUIET" to "BR_QUIET" for conformance Fabio Porcedda
2014-12-23 10:17 ` Thomas Petazzoni
2014-12-23 10:51 ` Fabio Porcedda
2014-12-28 16:24 ` Fabio Porcedda
2014-12-28 21:57 ` Yann E. MORIN [this message]
2014-12-30 10:59 ` Fabio Porcedda
2014-12-30 11:43 ` Fabio Porcedda
2014-12-23 8:54 ` [Buildroot] [PATCH v5 2/4] Makefile: improve detection of make "-s" flag Fabio Porcedda
2014-12-23 8:55 ` [Buildroot] [PATCH v5 3/4] support/download: silence svn if it is a silent build Fabio Porcedda
2014-12-23 8:55 ` [Buildroot] [PATCH v5 4/4] support/download: silence git " Fabio Porcedda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141228215747.GA5434@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox