From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/mke2img: do not overshoot user-specified size
Date: Sun, 28 Dec 2014 22:08:29 +0100 [thread overview]
Message-ID: <20141228220829.7fbea483@free-electrons.com> (raw)
In-Reply-To: <1419797482-28041-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Sun, 28 Dec 2014 21:11:22 +0100, Yann E. MORIN wrote:
> Currently, we forcibly expand the generated filesystem by 1300 blocks
> (i.e. a bit more than 1MiB) when we need to generate an ext3 or ext4
> filesystem, even if the user already supplied us with the size it wants
> the filesystem to be.
>
> In that case, we overshoot what the user requested, which is bad because
> the filesystem may no longer fit in the partition it is supposed to be
> written into.
>
> Only add extra blocks when we do compute the required size, not when the
> user specifies the size.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/mke2img/mke2img | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
Thanks, applied after doing some quick testing: an ext2 image with a
user-specified size, and an ext3 image with an automatically calculated
size.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-12-28 21:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 20:11 [Buildroot] [PATCH] package/mke2img: do not overshoot user-specified size Yann E. MORIN
2014-12-28 21:08 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141228220829.7fbea483@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox