Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v7 1/4] Makefile: improve detection of make "-s" flag
Date: Thu, 1 Jan 2015 17:03:25 +0100	[thread overview]
Message-ID: <20150101160325.GA4360@free.fr> (raw)
In-Reply-To: <1419947920-22047-2-git-send-email-fabio.porcedda@gmail.com>

Fabio, All,

On 2014-12-30 14:58 +0100, Fabio Porcedda spake thusly:
> Because it's just checked the presence of the "s" character even a
>   make --warn-undefined-variables
> is detected as a silent build so fix this by filtering out long options.
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> 
> Notes:
>     v6:
>      - use QUIET instead of BR_QUIET
>     v5:
>       - remove spaces after commas (Yann)
>     v4:
>       - split this patch from the patch set to send to muster as bugfix
>     v2:
>       - remove spurious space at the beginning of the QUIET variable (Arnout)
>     v4:
>       - split this patch from the patch set to send to muster as bugfix
>     v2:
>       - remove spurious space at the beginning of the QUIET variable (Arnout)
> 
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index e18a87e..c033620 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -303,7 +303,7 @@ GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
>  TARGETS :=
>  
>  # silent mode requested?
> -QUIET := $(if $(findstring s,$(MAKEFLAGS)),-q)
> +QUIET := $(if $(findstring s,$(filter-out --%,$(MAKEFLAGS))),-q)
>  
>  # Strip off the annoying quoting
>  ARCH := $(call qstrip,$(BR2_ARCH))
> -- 
> 2.1.0
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-01-01 16:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-30 13:58 [Buildroot] [PATCH v7 0/4] Improve silent builds Fabio Porcedda
2014-12-30 13:58 ` [Buildroot] [PATCH v7 1/4] Makefile: improve detection of make "-s" flag Fabio Porcedda
2015-01-01 16:03   ` Yann E. MORIN [this message]
2014-12-30 13:58 ` [Buildroot] [PATCH v7 2/4] pkg-download: silence check-hash if it is a silent build Fabio Porcedda
2015-01-01 16:16   ` Yann E. MORIN
2015-01-01 16:24   ` Yann E. MORIN
2014-12-30 13:58 ` [Buildroot] [PATCH v7 3/4] support/download: silence svn " Fabio Porcedda
2014-12-30 13:58 ` [Buildroot] [PATCH v7 4/4] support/download: silence git " Fabio Porcedda
2015-01-01 16:52 ` [Buildroot] [PATCH v7 0/4] Improve silent builds Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150101160325.GA4360@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox