From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Fri, 2 Jan 2015 13:25:03 +0100 Subject: [Buildroot] [PATCH 09/10] package/dvb-app: handle static/shared only build In-Reply-To: <1419717508-11627-10-git-send-email-romain.naour@openwide.fr> References: <1419717508-11627-1-git-send-email-romain.naour@openwide.fr> <1419717508-11627-10-git-send-email-romain.naour@openwide.fr> Message-ID: <20150102132503.7b9036cc@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Romain Naour, On Sat, 27 Dec 2014 22:58:27 +0100, Romain Naour wrote: > Signed-off-by: Romain Naour > --- > .../0003-handle-static-shared-only-build.patch | 35 ++++++++++++++++++++++ > .../dvb-apps/0003-support-static-only-build.patch | 20 ------------- > package/dvb-apps/dvb-apps.mk | 6 +++- > 3 files changed, 40 insertions(+), 21 deletions(-) > create mode 100644 package/dvb-apps/0003-handle-static-shared-only-build.patch > delete mode 100644 package/dvb-apps/0003-support-static-only-build.patch Does not build with the following configuration: BR2_arm=y BR2_TOOLCHAIN_EXTERNAL=y BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2014.11.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_17=y BR2_TOOLCHAIN_EXTERNAL_LARGEFILE=y BR2_TOOLCHAIN_EXTERNAL_INET_IPV6=y BR2_TOOLCHAIN_EXTERNAL_LOCALE=y # BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set BR2_TOOLCHAIN_EXTERNAL_INET_RPC=y BR2_TOOLCHAIN_EXTERNAL_CXX=y BR2_INIT_NONE=y BR2_SYSTEM_BIN_SH_NONE=y # BR2_PACKAGE_BUSYBOX is not set BR2_PACKAGE_DVB_APPS=y # BR2_TARGET_ROOTFS_TAR is not set It gives: CC dvbcfg_test arm-linux-gcc: error: ../../lib/libdvbcfg/libdvbcfg.a: Aucun fichier ou dossier de ce type ../../Make.rules:81: recipe for target 'dvbcfg_test' failed Do you actually test your patches before sending them? I don't mind seeing corner cases being broken, but here it's the canonical case: a BR2_SHARED_LIBS=y build (which is the default) on a major architecture (ARM). Patch rejected. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com