From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/janus-gateway: fix compilation with older gcc versions
Date: Sun, 4 Jan 2015 18:07:23 +0100 [thread overview]
Message-ID: <20150104180723.1b37f2e5@free-electrons.com> (raw)
In-Reply-To: <1420365575-25718-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Sun, 4 Jan 2015 10:59:35 +0100, Yann E. MORIN wrote:
> janus-gateway forcibly uses -Wunused-but-set-variable, which is not
> available for all gcc versions. For example, gcc-4.5, as used in
> Sourcery CodeBench PowerPC 2011.03, does not have it.
>
> Fixes:
> http://autobuild.buildroot.org/results/6d8/6d8e15ac5d592a51b6a8d2ceb9fc1ca954428ed7/
> http://autobuild.buildroot.org/results/abe/abe25b588bf6de0d76cce0135841d65dc66d5cca/
> [...]
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Gregory Dymarek <gregd72002@gmail.com>
I have an alternate version of this patch that does detect if
-Wunused-but-set-variable is supported by gcc or not, and uses it only
when available. I believe such a patch has a higher chance of being
accepted upstream, no?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-04 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 9:59 [Buildroot] [PATCH] package/janus-gateway: fix compilation with older gcc versions Yann E. MORIN
2015-01-04 17:07 ` Thomas Petazzoni [this message]
2015-01-04 17:18 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150104180723.1b37f2e5@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox