Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/erlang: fix detection of libatomic_ops
Date: Sun, 4 Jan 2015 21:32:09 +0100	[thread overview]
Message-ID: <20150104213209.0bd70205@free-electrons.com> (raw)
In-Reply-To: <1420381034-16098-1-git-send-email-yann.morin.1998@free.fr>

Yann, Frank,

On Sun,  4 Jan 2015 15:17:14 +0100, Yann E. MORIN wrote:
> For some platforms, hardware-assisted compare-and-swap may not be
> available, so libatomic will not provide it.
> 
> However, libatomic_ops can provide a puerly software CASE emulation, but

puerly -> purely
CASE -> CAS

> diff --git a/package/erlang/Config.in b/package/erlang/Config.in
> index 56830da..2eb9eba 100644
> --- a/package/erlang/Config.in
> +++ b/package/erlang/Config.in
> @@ -6,6 +6,8 @@ config BR2_PACKAGE_ERLANG
>  	depends on BR2_USE_MMU # fork()
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on !BR2_STATIC_LIBS
> +	depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS

 -> new dependency that must be propagated to the comment.

I've committed your patch with those two issues fixed, and I've added a
follow-up commit to further fix the dependencies of the comment, which
were already wrong.

Frank, do not hesitate to report about your testing after this patch.
It would be interesting if you could provide some simple test cases to
test the Erlang stuff, so that padawans like me can easily do a simple
testing of whether it still works or not.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2015-01-04 20:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-04 14:17 [Buildroot] [PATCH] package/erlang: fix detection of libatomic_ops Yann E. MORIN
2015-01-04 20:32 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150104213209.0bd70205@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox