From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] dmalloc: fix parallel builds
Date: Sun, 4 Jan 2015 21:41:57 +0100 [thread overview]
Message-ID: <20150104214157.4057d1ce@free-electrons.com> (raw)
In-Reply-To: <20150104190204.GA4224@vostro>
Dear Alex Suykov,
On Sun, 4 Jan 2015 21:02:04 +0200, Alex Suykov wrote:
> The following sequence seems to trigger it more or less reliably for me:
>
> ./configure --disable-static --enable-shared --enable-cxx --enable-threads
> sed -i -e "s at cat \$(srcdir)/dmalloc.h.1.*@&; sleep 1@" Makefile
> make clean
> make -j4
>
> What happens is a race condition between "cat ...; mv ... dmalloc.h"
> and "g++ -c dmallocc.cc". As long as cat-mv pair is faster, it works well.
> But if there's a delay, it breaks.
>
> This should be rare, I can only reproduce it with an artificial delay,
> and only with --disable-static. But on the other hand, it did happen
> on autobuild somehow.
Ok, thanks a lot for the explanation! I've committed your patch, with a
few minor tweaks:
[Thomas:
- Rename patch to the new naming convention.
- Add SoB line from Alex inside the patch itself.
- Adjust the commit log to contain the reference to the autobuilder
failure.]
If you're using dmalloc, I just noticed that the version we have in
Buildroot is 5.4.3, while upstream has a 5.5.2 release. If you want to
send a patch to bump the dmalloc version, that would be great.
Also, don't hesitate to send your patch to the upstream dmalloc
developers.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-04 20:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 11:05 [Buildroot] [PATCH] dmalloc: fix parallel builds Alex Suykov
2015-01-04 17:35 ` Thomas Petazzoni
2015-01-04 19:02 ` Alex Suykov
2015-01-04 20:41 ` Thomas Petazzoni [this message]
2015-01-07 13:02 ` Alex Suykov
2015-01-07 13:17 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150104214157.4057d1ce@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox