From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date: Sun, 4 Jan 2015 22:36:02 +0100
Subject: [Buildroot] [PATCH v4 05/17] erlang-goldrush: new package.
In-Reply-To: <1418135662-773-6-git-send-email-johan.oudinet@gmail.com>
References: <1418135662-773-1-git-send-email-johan.oudinet@gmail.com>
 <1418135662-773-6-git-send-email-johan.oudinet@gmail.com>
Message-ID: <20150104223602.09aaf9da@free-electrons.com>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Dear Johan Oudinet,

On Tue,  9 Dec 2014 15:34:10 +0100, Johan Oudinet wrote:
> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
> ---
>  package/Config.in                          |  5 +++++
>  package/erlang-goldrush/Config.in          |  6 ++++++
>  package/erlang-goldrush/erlang-goldrush.mk | 14 ++++++++++++++
>  3 files changed, 25 insertions(+)
>  create mode 100644 package/erlang-goldrush/Config.in
>  create mode 100644 package/erlang-goldrush/erlang-goldrush.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 600a68d..06c8e04 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -392,6 +392,11 @@ endmenu
>  menu "Interpreter languages and scripting"
>  	source "package/enscript/Config.in"
>  	source "package/erlang/Config.in"
> +if BR2_PACKAGE_ERLANG

So all Erlang packages are not visible unless erlang is enabled. Which
sounds good.

> +menu "Erlang libraries/modules"
> +	source "package/erlang-goldrush/Config.in"
> +endmenu
> +endif
>  	source "package/guile/Config.in"
>  	source "package/haserl/Config.in"
>  	source "package/jamvm/Config.in"
> diff --git a/package/erlang-goldrush/Config.in b/package/erlang-goldrush/Config.in
> new file mode 100644
> index 0000000..685a887
> --- /dev/null
> +++ b/package/erlang-goldrush/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_ERLANG_GOLDRUSH
> +	bool "erlang-goldrush"
> +	depends on BR2_PACKAGE_ERLANG

So why do we have this dependency again here?

> +	help
> +	  Goldrush is a small Erlang app that provides fast event
> +	  stream processing.
> diff --git a/package/erlang-goldrush/erlang-goldrush.mk b/package/erlang-goldrush/erlang-goldrush.mk
> new file mode 100644
> index 0000000..7537e76
> --- /dev/null
> +++ b/package/erlang-goldrush/erlang-goldrush.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# erlang-goldrush
> +#
> +################################################################################
> +
> +ERLANG_GOLDRUSH_VERSION = 0.1.6
> +ERLANG_GOLDRUSH_SITE = $(call github,DeadZen,goldrush,$(ERLANG_GOLDRUSH_VERSION))
> +ERLANG_GOLDRUSH_LICENSE_FILES = LICENSE

No <pkg>_LICENSE ?

> +ERLANG_GOLDRUSH_DEPENDENCIES = erlang host-erlang-rebar

Why are those dependencies necessary? Aren't they handled by the rebar
infra?

> +ERLANG_GOLDRUSH_INSTALL_STAGING = YES
> +
> +$(eval $(rebar-package))
> +$(eval $(host-rebar-package))

Might be good to say a word in the commit log to explain why a host
variant of this library is needed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com