Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] janus-gateway: add a patch to use -Wunused-but-set-variable only when available
Date: Mon, 5 Jan 2015 21:09:11 +0100	[thread overview]
Message-ID: <20150105210911.57f282cc@free-electrons.com> (raw)
In-Reply-To: <20150104174102.GB31970@free.fr>

Dear Yann E. MORIN,

On Sun, 4 Jan 2015 18:41:02 +0100, Yann E. MORIN wrote:

> Granted, for us Buildroot, that has virtually zero-impact, because the
> expanded code would be about the same you wrote. But if we want to
> upstream anything, better be using the state-of-the-art solution. ;-)
> 
> But anyway, why don't you simply write:
> 
>     AX_CHECK_COMPILE_FLAG([-Wunused-but-set-variable],
>         [GCC_WARN_UNUSED_BUT_SET=-Wunused-but-set-variable])
>     AC_SUBST([GCC_WARN_UNUSED_BUT_SET])
> 
> Also, as discused on IRC: add a comment in the .mk stating that
> AUTORECONF is needed because we also touch the autostuff.

Thanks for your comments. I adjusted my patch according to your
comments and applied it.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2015-01-05 20:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-04 17:27 [Buildroot] [PATCH] janus-gateway: add a patch to use -Wunused-but-set-variable only when available Thomas Petazzoni
2015-01-04 17:41 ` Yann E. MORIN
2015-01-05 20:09   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150105210911.57f282cc@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox