[Buildroot] [PATCH v4 03/17] package/pkg-rebar: new infrastructure

[Yann E. MORIN <yann.morin.1998@free.fr>]

Johan, All,

On 2015-01-05 12:13 +0100, Johan Oudinet spake thusly:
> On Mon, Jan 5, 2015 at 10:31 AM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
> > On Sun, 4 Jan 2015 23:20:38 +0100, Yann E. MORIN wrote:
> >> > > +# Define the build and install commands
> >> > > +#
> >> > > +ifeq ($(4),target)
> >> > > +
> >> > > +ifeq ($$($(2)_CONFIGURE),YES)
> >> >
> >> > What is $(2)_CONFIGURE exactly? It is not documented in PATCH 04/17.
> >>
> >> Some rebar packages use autotools for the configure step, and use rebar
> >> for the build step. Worse, some of them even require being autoreconf-ed.
> >>
> >> This variable, if set to YES, means that this package will use the
> >> autotools-package infrastrucutre; otherwise, it will be trated as a
> >> generic-package.
> >
> > Not sure of a better name for this one. Maybe $(2)_USE_AUTOTOOLS,
> > defaults to no, can be overridden to YES by the packages having a
> > configure script? Do they both autoconf and automake, or just autoconf?
> > I guess the latter, so maybe $(2)_USE_AUTOCONF.
> 
> They use autoconf only (mostly for the rebar.config.in file). So, I
> vote for $(2)_USE_AUTOCONF.

As I said in my reply to Thomas, I believe _CONFIGURE is really fit,
because that's what people expect: the package needs to be configured.

But, also as I said, if Thomas prefers we use an alternative, I'd say we
go for _AUTOTOOLS, as it matches the underlying infra we call to,
"autotools".

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'