From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/2] Makefile: pass host PKG_CONFIG_PATH at "make menuconfig" time
Date: Wed, 7 Jan 2015 21:33:21 +0100 [thread overview]
Message-ID: <20150107203321.GB4249@free.fr> (raw)
In-Reply-To: <1420243128-7708-2-git-send-email-bjorn.forsman@gmail.com>
Bj?rn, All,
On 2015-01-03 00:58 +0100, Bj?rn Forsman spake thusly:
> Buildroot unexports PKG_CONFIG_PATH in the top-level Makefile for purity
> reasons. But it has an unfortunate side-effect in that "make menuconfig"
> will not (necessarily) be able to pick up ncurses via host pkg-config,
> breaking "make menuconfig" on systems where ncurses is installed in a
> non-standard location.
>
> This patch saves the original PKG_CONFIG_PATH variable in
> HOST_PKG_CONFIG_PATH and restores the original PKG_CONFIG_PATH variable
> only in the sub-processes that builds the various menuconfig/nconfig/...
> targets.
>
> (PKG_CONFIG_PATH has to be placed in front of the make command so that it
> propagates to sub-processes. If given as an argument, it doesn't work.)
>
> Signed-off-by: Bj?rn Forsman <bjorn.forsman@gmail.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 5e0b4f2..0112853 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -264,6 +264,7 @@ export HOSTAR HOSTAS HOSTCC HOSTCXX HOSTFC HOSTLD
> export HOSTCC_NOCCACHE HOSTCXX_NOCCACHE
>
> # Make sure pkg-config doesn't look outside the buildroot tree
> +HOST_PKG_CONFIG_PATH := $(PKG_CONFIG_PATH)
> unexport PKG_CONFIG_PATH
> unexport PKG_CONFIG_SYSROOT_DIR
> unexport PKG_CONFIG_LIBDIR
> @@ -692,7 +693,8 @@ export HOSTCFLAGS
>
> $(BUILD_DIR)/buildroot-config/%onf:
> mkdir -p $(@D)/lxdialog
> - $(MAKE) CC="$(HOSTCC_NOCCACHE)" HOSTCC="$(HOSTCC_NOCCACHE)" obj=$(@D) -C $(CONFIG) -f Makefile.br $(@F)
> + PKG_CONFIG_PATH="$(HOST_PKG_CONFIG_PATH)" $(MAKE) CC="$(HOSTCC_NOCCACHE)" HOSTCC="$(HOSTCC_NOCCACHE)" \
> + obj=$(@D) -C $(CONFIG) -f Makefile.br $(@F)
>
> DEFCONFIG = $(call qstrip,$(BR2_DEFCONFIG))
>
> --
> 2.1.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-01-07 20:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-02 23:58 [Buildroot] [PATCH v3 0/2] Portability fixes for "make menuconfig" Bjørn Forsman
2015-01-02 23:58 ` [Buildroot] [PATCH v3 1/2] Makefile: pass host PKG_CONFIG_PATH at "make menuconfig" time Bjørn Forsman
2015-01-07 20:33 ` Yann E. MORIN [this message]
2015-01-02 23:58 ` [Buildroot] [PATCH v3 2/2] kconfig/lxdialog: get ncurses CFLAGS with pkg-config Bjørn Forsman
2015-01-07 20:34 ` Yann E. MORIN
2015-01-07 21:28 ` [Buildroot] [PATCH v3 0/2] Portability fixes for "make menuconfig" Thomas Petazzoni
2015-01-07 21:52 ` Bjørn Forsman
2015-01-08 8:18 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107203321.GB4249@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox