From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/8] boot/uboot: Replace TARGET_CONFIGURE_OPTS with TARGET_MAKE_ENV
Date: Sat, 10 Jan 2015 16:39:48 +0100 [thread overview]
Message-ID: <20150110163948.336837a9@free-electrons.com> (raw)
In-Reply-To: <1420897647-25001-3-git-send-email-jkrause@posteo.de>
Dear J?rg Krause,
On Sat, 10 Jan 2015 14:47:21 +0100, J?rg Krause wrote:
> Use TARGET_MAKE_ENV instead of TARGET_CONFIGURE_OPTS for building the U-Boot
> target with 'make <board>_(def)config' and 'make'.
>
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
Why? TARGET_CONFIGURE_OPTS is clearly not the same as TARGET_MAKE_ENV.
While I agree that TARGET_MAKE_ENV should be passed, the commit log
should contain an explanation as to why TARGET_CONFIGURE_OPTS is not
necessary.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-10 15:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-10 13:47 [Buildroot] [PATCH v2 0/8] Add support for U-Boots Kbuild & Kconfig build system Jörg Krause
2015-01-10 13:47 ` [Buildroot] [PATCH v2 1/8] boot/uboot: Remove obsolete CONFIG_NOSOFTFLOAT flag Jörg Krause
2015-01-10 15:39 ` Thomas Petazzoni
2015-01-10 13:47 ` [Buildroot] [PATCH v2 2/8] boot/uboot: Replace TARGET_CONFIGURE_OPTS with TARGET_MAKE_ENV Jörg Krause
2015-01-10 15:39 ` Thomas Petazzoni [this message]
2015-01-10 13:47 ` [Buildroot] [PATCH v2 3/8] boot/uboot: Add support for Kbuild & Kconfig build system Jörg Krause
2015-01-10 15:43 ` Thomas Petazzoni
2015-01-10 13:47 ` [Buildroot] [PATCH v2 4/8] boot/uboot: Add uboot-menuconfig and friends Jörg Krause
2015-01-10 15:43 ` Thomas Petazzoni
2015-01-15 20:55 ` Jörg Krause
2015-01-10 13:47 ` [Buildroot] [PATCH v2 5/8] docs/manual/make-tips.mk: Add uboot documentation Jörg Krause
2015-01-10 13:47 ` [Buildroot] [PATCH v2 6/8] docs/manual/customize-configuration.txt: " Jörg Krause
2015-01-10 13:47 ` [Buildroot] [PATCH v2 7/8] docs/manual/customize-quick-guide.txt: " Jörg Krause
2015-01-10 13:47 ` [Buildroot] [PATCH v2 8/8] docs/manual/configure-other-components.txt: " Jörg Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150110163948.336837a9@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox