From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] qt: split script and webkit supported arches in two different variables
Date: Sat, 10 Jan 2015 18:24:44 +0100 [thread overview]
Message-ID: <20150110182444.3ede8a44@free-electrons.com> (raw)
In-Reply-To: <1417712399-6394-1-git-send-email-Vincent.Riera@imgtec.com>
Dear Vicente Olivert Riera,
On Thu, 4 Dec 2014 16:59:59 +0000, Vicente Olivert Riera wrote:
> Currently in Buildroot we have a BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
> variable indicating which architectures support Qt Webkit. We also make
> Qt Script depending on that variable, so we are assuming that Qt Script
> is supported for exactly the same architectures which support Qt Webkit,
> and that's not true.
>
> For instance, Qt Webkit is not supported for MIPS64 when
> using the n32 ABI, but Qt Script is actually supported. So, if we make
> BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT depending on !BR2_MIPS_NABI32 we
> will also disable Qt Script, because as I said before, Qt Script depends
> on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT, and we don't want that because
> Qt Script works.
>
> We fix this by creating another variable called
> BR2_PACKAGE_QT_ARCH_SUPPORTS_SCRIPT to state which architectures support
> Qt Script, so now we can differentiate them from the ones supporting Qt
> Webkit.
>
> Related:
> http://lists.busybox.net/pipermail/buildroot/2014-November/112605.html
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-01-10 17:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 16:59 [Buildroot] [PATCH v2] qt: split script and webkit supported arches in two different variables Vicente Olivert Riera
2015-01-10 17:24 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150110182444.3ede8a44@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox