From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/4] dtc: fix project and download url
Date: Mon, 12 Jan 2015 21:39:37 +0100 [thread overview]
Message-ID: <20150112213937.4af8de78@free-electrons.com> (raw)
In-Reply-To: <1421000166-24963-1-git-send-email-ps.report@gmx.net>
Dear Peter Seiderer,
On Sun, 11 Jan 2015 19:16:03 +0100, Peter Seiderer wrote:
> and rename patches to new convention
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> package/dtc/0001-separate-lib-install.patch | 28 +++++++++++++++++++++++++
> package/dtc/0002-extra-cflags.patch | 32 +++++++++++++++++++++++++++++
> package/dtc/Config.in | 2 +-
> package/dtc/dtc-extra_cflags.patch | 32 -----------------------------
> package/dtc/dtc-separate-lib-install.patch | 28 -------------------------
> package/dtc/dtc.mk | 5 +++--
> 6 files changed, 64 insertions(+), 63 deletions(-)
> create mode 100644 package/dtc/0001-separate-lib-install.patch
> create mode 100644 package/dtc/0002-extra-cflags.patch
> delete mode 100644 package/dtc/dtc-extra_cflags.patch
> delete mode 100644 package/dtc/dtc-separate-lib-install.patch
Thanks. I was going to apply this, but since PATCH 2 has some issues,
I'll give some minor comments on this one as well:
1/ You're doing two separate things here: change the project URL, and
rename the patches. So this should be done in two separate patches.
2/ Please enable rename detection in Git, so we can clearly see in the
patch that it's a rename.
Can you resend with this fixed?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-12 20:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-11 18:16 [Buildroot] [PATCH v2 1/4] dtc: fix project and download url Peter Seiderer
2015-01-11 18:16 ` [Buildroot] [PATCH v2 2/4] dtc: bump version to 1.4.1 Peter Seiderer
2015-01-12 20:07 ` Thomas Petazzoni
2015-01-12 22:13 ` Peter Seiderer
2015-01-11 18:16 ` [Buildroot] [PATCH v2 3/4] dtc: add host build Peter Seiderer
2015-01-12 20:42 ` Thomas Petazzoni
2015-01-12 22:31 ` Peter Seiderer
2015-01-11 18:16 ` [Buildroot] [PATCH v2 4/4] dtc: add patches for raspberry pi overlay support Peter Seiderer
2015-01-12 13:57 ` Matthew Weber
2015-01-12 16:01 ` Peter Seiderer
2015-01-12 20:50 ` Thomas Petazzoni
2015-01-12 22:39 ` Peter Seiderer
2015-01-12 20:39 ` Thomas Petazzoni [this message]
2015-01-12 22:15 ` [Buildroot] [PATCH v2 1/4] dtc: fix project and download url Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150112213937.4af8de78@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox