Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/nodejs: fix hard float error
Date: Mon, 12 Jan 2015 22:18:27 +0100	[thread overview]
Message-ID: <20150112221827.7ed3765d@free-electrons.com> (raw)
In-Reply-To: <1421095921-2816-1-git-send-email-jkrause@posteo.de>

Dear J?rg Krause,

On Mon, 12 Jan 2015 21:52:01 +0100, J?rg Krause wrote:

> +# V8 needs to know what floating point ABI the target is using.
> +NODEJS_ARM_FP = $(BR2_GCC_TARGET_FLOAT_ABI)

Since this variable is a string, I've added a $(call qstrip,...), for
good measure. And then applied your patch, thanks!

Since you're looking at nodejs, can you have a look at the thread
http://lists.busybox.net/pipermail/buildroot/2014-November/112880.html
(which contains one patch), and send an updated patch series to make
the necessary modifications? They looked good in principle, but not
nicely separated in multiple patches.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-01-12 21:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12 20:52 [Buildroot] [PATCH v2 1/1] package/nodejs: fix hard float error Jörg Krause
2015-01-12 21:18 ` Thomas Petazzoni [this message]
2015-01-12 21:35   ` Jörg Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150112221827.7ed3765d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox