From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] linux/linux.mk: fixed downloading kernel patches
Date: Tue, 13 Jan 2015 19:23:48 +0100 [thread overview]
Message-ID: <20150113182348.GA7168@free.fr> (raw)
In-Reply-To: <54B4F427.7080405@gmail.com>
Ivo, All,
On 2015-01-13 11:32 +0100, Ivo Slanina spake thusly:
> On 01/12/2015 10:38 PM, Yann E. MORIN wrote:
> > Ivo, All,
> > On 2015-01-12 17:37 +0100, Ivo Slanina spake thusly:
> >> Patches located at ftp or http(s) URLs were downloaded using DOWNLOAD
> >> macro. For example, if linux source was located at external git
> >> repository, DOWNLOAD macro uses git scheme as well and buildroot
> >> tried to downlod a path using DOWNLOAD_GIT macro. As a result, nothing
> >> was downloaded and build siletly passes.
[--SNIP--]
> > Which still prompts a question: what if the user has patches he want to
> > download via scp? We do not handle this case for now, right. Should we?
>
> Yes, this is true. Another solution would be to add optional parameter
> to DOWNLOAD macro in order to force execute scheme="$(call geturischeme,$(1))".
>
> When I get back from my work, I'll send another patch version :)
No need to "fix" your patch: it is just correct, that's why I replied
with:
> > Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Supporting scp would be a new feature, so shouold be done in a separate
patch. You are welcome to provide such another patch if you want, of
course! ;-)
Thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-01-13 18:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 16:37 [Buildroot] [PATCH 1/2] linux/linux.mk: added https:// pattern for kernel patches Ivo Slanina
2015-01-12 16:37 ` [Buildroot] [PATCH 2/2] linux/linux.mk: fixed downloading " Ivo Slanina
2015-01-12 21:38 ` Yann E. MORIN
2015-01-13 10:32 ` Ivo Slanina
2015-01-13 18:23 ` Yann E. MORIN [this message]
2015-01-12 21:17 ` [Buildroot] [PATCH 1/2] linux/linux.mk: added https:// pattern for " Yann E. MORIN
2015-01-14 15:55 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150113182348.GA7168@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox