From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain: Use the correct target name
Date: Fri, 16 Jan 2015 09:29:44 +0100 [thread overview]
Message-ID: <20150116092944.06e31910@free-electrons.com> (raw)
In-Reply-To: <54B843D7.1030602@dawncrow.de>
Dear Andr? Hentschel,
On Thu, 15 Jan 2015 23:48:55 +0100, Andr? Hentschel wrote:
> When using an external toolchain we need to use the toolchain prefix
> for the staging directory and e.g. for configure.
>
> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
> ---
> This fixes cross compiling Wine (not yet upstream because of that).
>
> package/Makefile.in | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index 2055f00..0a00c7e 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -36,7 +36,11 @@ $(error BR2_TOOLCHAIN_BUILDROOT_VENDOR cannot be 'unknown'. \
> endif
>
> # Compute GNU_TARGET_NAME
> +ifeq ($(BR2_TOOLCHAIN_BUILDROOT),y)
> GNU_TARGET_NAME = $(ARCH)-$(TARGET_VENDOR)-$(TARGET_OS)-$(LIBC)$(ABI)
> +else
> +GNU_TARGET_NAME = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_PREFIX))
> +endif
I am not sure we want to do this actually. There is nothing that forces
the toolchain to have the same prefix as the host tuple. Except Wine
and its original build system.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-16 8:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 22:48 [Buildroot] [PATCH] toolchain: Use the correct target name André Hentschel
2015-01-16 8:29 ` Thomas Petazzoni [this message]
2015-01-18 12:45 ` André Hentschel
2015-01-18 16:27 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116092944.06e31910@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox