From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] bootlader/grub2: disable x86-64-efi choice on !BR2_ARCH_IS_64
Date: Sun, 18 Jan 2015 16:42:33 +0100 [thread overview]
Message-ID: <20150118154233.GM4275@free.fr> (raw)
In-Reply-To: <1421431115-5202-1-git-send-email-s.martin49@gmail.com>
Samuel, All,
On 2015-01-16 18:58 +0100, Samuel Martin spake thusly:
> When x86-64-efi platform is selected, grub2 automatically adds -m64 to the
> CFLAGS. This makes the configure script failed when the toolchain does not
> have multilib support (like the Buildroot ones).
>
> Reported-by: Noe Rubinstein <nrubinstein@aldebaran-robotics.com>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
I fail to see a case where we would want to build a 64-bit EFI GRUB to
later start a 32-bit kernel and userland.
Since we do not support multilib, the user would have to have two
builds: one for the 32-bit kernel+userland, one for the 64-bit
bootloader (if that is even possible to boot a 32-bit kernel from a
64-bit EFI GRUB).
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> boot/grub2/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/boot/grub2/Config.in b/boot/grub2/Config.in
> index 626344a..c465a4d 100644
> --- a/boot/grub2/Config.in
> +++ b/boot/grub2/Config.in
> @@ -132,6 +132,7 @@ config BR2_TARGET_GRUB2_I386_EFI
>
> config BR2_TARGET_GRUB2_X86_64_EFI
> bool "x86-64-efi"
> + depends on BR2_ARCH_IS_64
> help
> Select this option if the platform you're targetting has a
> 64 bits EFI BIOS.
> --
> 2.1.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-01-18 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 17:58 [Buildroot] [PATCH] bootlader/grub2: disable x86-64-efi choice on !BR2_ARCH_IS_64 Samuel Martin
2015-01-18 15:42 ` Yann E. MORIN [this message]
2015-02-03 11:11 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150118154233.GM4275@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox