Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] use TARGET_CONFIGURE_OPTS instead of homegrown ENV
Date: Thu, 22 Jan 2015 22:51:54 +0100	[thread overview]
Message-ID: <20150122215154.GA3970@free.fr> (raw)
In-Reply-To: <CANxTyt7+xC2zY3W7M-njuAC4P1wP1NKC-wQQt6yM_odzOr7Hsw@mail.gmail.com>

Danomi, David,All,

On 2015-01-22 16:32 -0500, Danomi Manchego spake thusly:
> David,
> Seems like you should have squashed this into a single "cigic: new
> package" patch, no?  Forgot to rebase?

In fact, I asked David to send his patches as-is, because we discussed
on IRC an issue remaining about licensing information that did not get
saved for some of the packages while it got saved for the others.

I was supposed to review the patches tonight (UTC+1), but got delayed
due to heavy electricity work in the house...

Of course, you are entirely right: the patches about each single package
should have been squahes. That can be done later when we have solved the
licensing info issue.

Thanks for your early review! ;-)

Regards,
Yann E. MORIN.

> On Thu, Jan 22, 2015 at 2:11 PM, David Bender <codehero@gmail.com> wrote:
> >
> > Signed-off-by: David Bender <codehero@gmail.com>
> > ---
> >  package/cgic/cgic.mk |    7 ++-----
> >  1 files changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/package/cgic/cgic.mk b/package/cgic/cgic.mk
> > index 378e1cd..a575a16 100644
> > --- a/package/cgic/cgic.mk
> > +++ b/package/cgic/cgic.mk
> > @@ -9,14 +9,11 @@ CGIC_SOURCE = cgic206.tar.gz
> >  CGIC_SITE = http://boutell.com/cgic
> >  CGIC_LICENSE = Custom
> >  CGIC_LICENSE_FILES = license.txt
> > -
> > -CGIC_ENV = AR=$(TARGET_CROSS)ar \
> > -       CC=$(TARGET_CROSS)gcc \
> > -       RANLIB=$(TARGET_CROSS)ranlib
> > +CGIC_INSTALL_STAGING = YES
> >
> >  define CGIC_BUILD_CMDS
> >         (cd $(@D); \
> > -               $(CGIC_ENV) \
> > +               $(TARGET_CONFIGURE_OPTS) \
> >                 make libcgic.a \
> >                 )
> >  endef
> > --
> > 1.7.8.6
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-01-22 21:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16 16:23 [Buildroot] [PATCH 1/1] cgic: new package David Bender
2015-01-17 19:21 ` Baruch Siach
2015-01-22 19:11   ` [Buildroot] [PATCH 1/3] " David Bender
2015-01-22 19:11     ` [Buildroot] [PATCH 2/3] Restore cgiFormFileGetTempfileName and make creation permissions more secure David Bender
2015-01-25 15:53       ` Yann E. MORIN
2015-01-22 19:11     ` [Buildroot] [PATCH 3/3] use TARGET_CONFIGURE_OPTS instead of homegrown ENV David Bender
2015-01-22 21:32       ` Danomi Manchego
2015-01-22 21:51         ` Yann E. MORIN [this message]
2015-01-22 21:25     ` [Buildroot] [PATCH 1/3] cgic: new package Danomi Manchego
2015-01-25 14:53     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150122215154.GA3970@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox