From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] python-jinja2: allow build as host-package
Date: Tue, 27 Jan 2015 22:14:31 +0100 [thread overview]
Message-ID: <20150127221431.14835106@free-electrons.com> (raw)
In-Reply-To: <54C7FE07.4030206@mind.be>
Dear Arnout Vandecappelle,
On Tue, 27 Jan 2015 22:07:19 +0100, Arnout Vandecappelle wrote:
> > While currently there are no in-tree Buildroot packages which depend on
> > host-python-jinja2, I'm currently having to deal with a proprietary
> > software build system that requires it.
>
> Forgot to mention in my last review: in that case, you should also add a
> Config.in.host for it (and update package/Config.in.host).
Why ? If it's merely used as a build dependency of another package, I
don't see why we should have a menuconfig entry for it. Indeed, having
a host-python-ninja2 package with no users in-tree is weird, but I
don't think cluttering the "Host utilities" menu with such packages is
the appropriate solution here.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-27 21:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 17:25 [Buildroot] [PATCH v2 1/2] python-markupsafe: allow build as host package Erico Nunes
2015-01-26 17:25 ` [Buildroot] [PATCH v2 2/2] python-jinja2: allow build as host-package Erico Nunes
2015-01-27 21:07 ` Arnout Vandecappelle
2015-01-27 21:14 ` Thomas Petazzoni [this message]
2015-01-27 21:19 ` Arnout Vandecappelle
2015-01-28 14:56 ` DATACOM - Erico Nunes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127221431.14835106@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox