From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/3] pkg-generic.mk: reinstall targets
Date: Sun, 1 Feb 2015 11:59:13 +0100 [thread overview]
Message-ID: <20150201115913.4c61b7ad@free-electrons.com> (raw)
In-Reply-To: <20150201105500.GA4305@free.fr>
Dear Yann E. MORIN,
On Sun, 1 Feb 2015 11:55:01 +0100, Yann E. MORIN wrote:
> I am not very happy with the fact that we add new actions here; the rest
> of the code block is so far only concerned about ordering, not the
> actual commands to execute.
>
> The only other similar make target that removes stuff is the
> $(1)-dirclean target, that uses a fake stamp-file (that it actually does
> not touch) to actually does the cleanup.
I am not sure what you mean here. Look at the existing
$(1)-clean-for-rebuild and $(1)-clean-for-reconfigure targets. They
also do some commands to remove the stamp files. So what Doug has done
here is to simply replicate the same logic, but removing less stamp
files to only retrigger installation and not configuration and/or
compilation.
So I believe the implementation proposed by Doug is well-aligned with
what we already do. Unless I misunderstood your comment, obviously.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-02-01 10:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 15:25 [Buildroot] [PATCH v3 0/3] [RFC] Reinstall Targets Doug Kehn
2014-11-28 15:25 ` [Buildroot] [PATCH v3 1/3] pkg-generic.mk: reinstall targets Doug Kehn
2015-02-01 10:55 ` Yann E. MORIN
2015-02-01 10:59 ` Thomas Petazzoni [this message]
2015-02-01 11:19 ` Yann E. MORIN
2015-02-03 17:11 ` Thomas Petazzoni
2014-11-28 15:25 ` [Buildroot] [PATCH v3 2/3] manual: " Doug Kehn
2015-02-03 17:11 ` Thomas Petazzoni
2015-02-03 17:49 ` rdkehn at yahoo.com
2014-11-28 15:25 ` [Buildroot] [PATCH v3 3/3] manual: style update Doug Kehn
2015-02-03 17:12 ` Thomas Petazzoni
2014-12-10 18:42 ` [Buildroot] [PATCH v3 0/3] [RFC] Reinstall Targets Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150201115913.4c61b7ad@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox