Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Suykov <alex.suykov@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/benejson: disable for static-only builds
Date: Sun, 1 Feb 2015 19:56:01 +0200	[thread overview]
Message-ID: <20150201175601.GA28929@vostro> (raw)
In-Reply-To: <1422743798-18921-1-git-send-email-yann.morin.1998@free.fr>

Sat, Jan 31, 2015 at 11:36:38PM +0100, Yann E. MORIN wrote:

> benejson does not know how to build static-only libraries. as well,
> it is not able to build shared-only libs either.
Well, actually scons allows specifying targets explicitly.

Benejson is just a small library, so it should not cause much
trouble later. And there's already a similar block with install
commands anyway.


--- a/package/benejson/benejson.mk
+++ b/package/benejson/benejson.mk
@@ -20,10 +20,18 @@ endef
 BENEJSON_POST_PATCH_HOOKS += BENEJSON_DISABLE_WCHAR
 endif
 
+BENEJSON_SCONS_TARGETS = include
+ifeq ($(BR2_STATIC_LIBS)$(BR2_SHARED_STATIC_LIBS),y)
+BENEJSON_SCONS_TARGETS += lib/libbenejson.a
+endif
+ifeq ($(BR2_SHARED_LIBS)$(BR2_SHARED_STATIC_LIBS),y)
+BENEJSON_SCONS_TARGETS += lib/libbenejson.so
+endif
+
 define BENEJSON_BUILD_CMDS
 	(cd $(@D); \
 		$(TARGET_CONFIGURE_OPTS) CROSS=$(TARGET_CROSS) \
-		$(SCONS))
+		$(SCONS) $(BENEJSON_SCONS_TARGETS))
 endef
 
 ifeq ($(BR2_STATIC_LIBS)$(BR2_SHARED_STATIC_LIBS),y)

      reply	other threads:[~2015-02-01 17:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-31 22:36 [Buildroot] [PATCH] package/benejson: disable for static-only builds Yann E. MORIN
2015-02-01 17:56 ` Alex Suykov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150201175601.GA28929@vostro \
    --to=alex.suykov@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox