From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] Add hash file
Date: Mon, 2 Feb 2015 10:50:16 +0100 [thread overview]
Message-ID: <20150202105016.4b24eddf@free-electrons.com> (raw)
In-Reply-To: <1422855653-6338-2-git-send-email-skenton@ou.edu>
Dear Steve Kenton,
On Mon, 2 Feb 2015 05:40:53 +0000, Steve Kenton wrote:
> Signed-off-by: Steve Kenton <skenton@ou.edu>
> ---
> package/cdrtools/cdrtools.hash | 3 +++
> 1 file changed, 3 insertions(+)
> create mode 100644 package/cdrtools/cdrtools.hash
This patch should not be separated from the previous, it should be
merged with it.
>
> diff --git a/package/cdrtools/cdrtools.hash b/package/cdrtools/cdrtools.hash
> new file mode 100644
> index 0000000..c9f9c29
> --- /dev/null
> +++ b/package/cdrtools/cdrtools.hash
> @@ -0,0 +1,3 @@
> +cdrtools-3.00.tar.gz 2010-06-02 2.5 MB 6363 weekly downloads i
This line doesn't make sense in a hash file. There should instead be a
comment saying where the hashes are coming from. Something like:
# From http://sourceforge.net/....
or
# Locally computed
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-02-02 9:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 5:40 [Buildroot] [PATCH 1/2] Cdrtools is a set of command line programs that allows to record CD/DVD/BluRay media. This package contains the cdrecord & mkisofs programs Steve Kenton
2015-02-02 5:40 ` [Buildroot] [PATCH 2/2] Add hash file Steve Kenton
2015-02-02 9:50 ` Thomas Petazzoni [this message]
2015-02-02 15:03 ` Steve Kenton
2015-02-02 16:55 ` Thomas Petazzoni
2015-02-02 9:35 ` [Buildroot] [PATCH 1/2] Cdrtools is a set of command line programs that allows to record CD/DVD/BluRay media. This package contains the cdrecord & mkisofs programs Thomas Petazzoni
2015-02-02 14:59 ` Steve Kenton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202105016.4b24eddf@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox