Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] package/mesa3d: Refactor XA support to prepare support for ATI drivers
Date: Mon, 2 Feb 2015 21:40:53 +0100	[thread overview]
Message-ID: <20150202214053.618db057@free-electrons.com> (raw)
In-Reply-To: <1421514235-27122-1-git-send-email-bernd.kuhls@t-online.de>

Dear Bernd Kuhls,

On Sat, 17 Jan 2015 18:03:54 +0100, Bernd Kuhls wrote:
> --
> v2: - rebased patch by micro1183: http://patchwork.ozlabs.org/patch/398857/

This shouldn't be part of the commit log, but should be...

> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---

... here, i.e below the "---" sign.

> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
> index eb977b6..6b3ccce 100644
> --- a/package/mesa3d/Config.in
> +++ b/package/mesa3d/Config.in
> @@ -43,6 +43,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU
>  	depends on BR2_i386 || BR2_x86_64
>  	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
>  	select BR2_PACKAGE_LIBDRM_NOUVEAU
> +	select BR2_PACKAGE_MESA3D_NEEDS_XA
>  	help
>  	  Supports all Nvidia GPUs.
>  
> @@ -51,6 +52,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA
>  	depends on BR2_i386 || BR2_x86_64
>  	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
>  	select BR2_PACKAGE_LIBDRM_VMWGFX
> +	select BR2_PACKAGE_MESA3D_NEEDS_XA
>  	help
>  	  This is a virtual GPU driver for VMWare virtual machines.
>  
> @@ -61,6 +63,9 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST
>  	  This is a software opengl implementation using the Gallium3D
>  	  infrastructure.
>  
> +config BR2_PACKAGE_MESA3D_NEEDS_XA
> +	bool

I've moved this new blind option next to the other existing blind
options in the package.

>  MESA3D_CONF_OPTS += --enable-glx
>  # quote from mesa3d configure "Building xa requires at least one non swrast gallium driver."
> -ifneq ($(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU)$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA),)
> +ifneq ($(BR2_PACKAGE_MESA3D_NEEDS_XA),)

We could now use positive logic here. I'll switch to that in a
follow-up commit.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2015-02-02 20:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-17 17:03 [Buildroot] [PATCH v2 1/2] package/mesa3d: Refactor XA support to prepare support for ATI drivers Bernd Kuhls
2015-01-17 17:03 ` [Buildroot] [PATCH v2 2/2] package/mesa3d: Enable support for Radeon r600 gallium driver Bernd Kuhls
2015-02-02 20:44   ` Thomas Petazzoni
2015-02-02 20:40 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150202214053.618db057@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox