From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Export BR2_EXTERNAL for post-build/support scripts
Date: Wed, 4 Feb 2015 17:19:07 +0100 [thread overview]
Message-ID: <20150204161907.GB4586@free.fr> (raw)
In-Reply-To: <1423064097-1151-1-git-send-email-julian@jusst.de>
Julian, All,
On 2015-02-04 16:34 +0100, Julian Scheel spake thusly:
> Especially post-build scripts might want to make use of BR2_EXTERNAL variable,
> so export it.
As discussed on IRC, there is another solution to export BR2_EXTERNAL,
which is to add it to EXTRA_ENV, like so:
br2-external: make it available to post-{build,image} scripts
Currently, BR2_EXTERNAL is not always exported to sub-processes that we
spawn, like post-build or post-image scripts. This all depends on how
the user passes BR2_EXTERNAL; consider the following:
- make BR2_EXTERNAL=/path/to/br2-ext
- BR2_EXTERNAL=/path/to/br2-ext make
In the first case, it is just a make variable, not an environment
variable, and thus not exported, while in the second case it is an
environment variable and gets exported to all sub-processes make may
spawn.
Explicitly export it using EXTRA_ENV.
Reported-by: Julian Scheel <julian@jusst.de>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/Makefile.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/Makefile.in b/package/Makefile.in
index 70529f8..803b162 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -326,7 +326,8 @@ HOST_MAKE_ENV = \
EXTRA_ENV = \
PATH=$(BR_PATH) \
BR2_DL_DIR=$(BR2_DL_DIR) \
-BUILD_DIR=$(BUILD_DIR)
+BUILD_DIR=$(BUILD_DIR) \
+BR2_EXTERNAL=$(BR2_EXTERNAL)
################################################################################
# settings we need to pass to configure
Regards,
Yann E. MORIN.
> Signed-off-by: Julian Scheel <julian@jusst.de>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index e554a30..92ae3fa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -349,6 +349,7 @@ endif
> # Scripts in support/ or post-build scripts may need to reference
> # these locations, so export them so it is easier to use
> export BR2_CONFIG
> +export BR2_EXTERNAL
> export TARGET_DIR
> export STAGING_DIR
> export HOST_DIR
> --
> 2.2.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-02-04 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 15:34 [Buildroot] [PATCH] Export BR2_EXTERNAL for post-build/support scripts Julian Scheel
2015-02-04 16:19 ` Yann E. MORIN [this message]
2015-02-04 16:21 ` Yann E. MORIN
2015-02-07 15:11 ` Romain Naour
2015-02-07 21:48 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150204161907.GB4586@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox