From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] cryptsetup: remove hard dependency on libgcrypt
Date: Thu, 5 Feb 2015 08:57:05 +0100 [thread overview]
Message-ID: <20150205085705.5edbc489@free-electrons.com> (raw)
In-Reply-To: <54D27FAC.4050004@je-eigen-domein.nl>
Dear Floris Bos,
On Wed, 04 Feb 2015 21:23:08 +0100, Floris Bos wrote:
> On 02/04/2015 08:56 PM, Thomas Petazzoni wrote:
> > On Wed, 4 Feb 2015 19:33:28 +0100, Floris Bos wrote:
> >
> >> - Removes CRYPTSETUP_AUTORECONF as it is redundant, and reconf does
> >> create a dependency on libgcrypt for the m4 macros used.
> > This essentially reverts commit
> > d66c981aaa2248b7e20a4f802f3643435a1761ca, which was made to fix
> > http://autobuild.buildroot.net/results/9ca/9cad1cf49ee6b5c58d8260ee33beef2e6c1ada4d/.
>
> d66c981aaa2248b7e20a4f802f3643435a1761ca was already reverted by commit
> 40c341da78f3315fa31e4ea56b470753bf915a31 which bumped version again and
> removed cryptsetup-0001-link-against-lrt-for-clock_gettime.patch that
> modified configure.ac
>
> Looks to me that removing the autoreconf was simply overlooked there.
Ah, indeed! Would have been good to mention in the commit log, then.
> > Can you rebuild the same configuration and see if with your patch it
> > builds fine?
>
> That configuration does not work with today's buildroot due to unrelated
> reasons.
> Invalid lua package selection combination, and a long list of legacy
> options.
Yes, obviously old configurations may need some tweaking to build, to
remove legacy options.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-02-05 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 18:33 [Buildroot] [PATCH] cryptsetup: remove hard dependency on libgcrypt Floris Bos
2015-02-04 18:33 ` [Buildroot] [PATCH v2] dropbear: add extra build customization options Floris Bos
2015-02-07 12:00 ` Peter Korsgaard
2015-02-04 19:56 ` [Buildroot] [PATCH] cryptsetup: remove hard dependency on libgcrypt Thomas Petazzoni
2015-02-04 20:23 ` Floris Bos
2015-02-05 7:57 ` Thomas Petazzoni [this message]
2015-03-08 21:16 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205085705.5edbc489@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox