Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] glibc: add version 2.21
Date: Sun, 8 Feb 2015 18:29:13 +0100	[thread overview]
Message-ID: <20150208172913.GM4028@free.fr> (raw)
In-Reply-To: <20150208172043.GL16955@sapphire.tkos.co.il>

On 2015-02-08 19:20 +0200, Baruch Siach spake thusly:
> Hi Vicente,
> 
> On Sun, Feb 08, 2015 at 03:07:05PM +0000, Vicente Olivert Riera wrote:
> > - Add version 2.21
> > - Add a hash value for it
> > 
> > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> 
> The glibc NEWS for the 2.21 release[1] include this:
> 
> * The GNU C Library is now built with -Werror by default.  This can be
>   disabled by configuring with --disable-werror.

Yup, I had seen this. And I think this is a good idea for such a
critical piece of code.

> I think we should add --disable-werror when configuring glibc 2.21.

Why so? I think on the contrary we should keep the default, and only if
we find issues then we can investigate as to whether this is a real
error or not, and report that upstream.

Granted, we usually remove -Werror from packages when they fail to build
(and I am not a big fan of it, warnings should not be treated lightly),
but only in that case. If the package builds fine with -Werror, we
usually keep it.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-02-08 17:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-08 15:07 [Buildroot] [PATCH 0/3] glibc: bump version to 2.21 Vicente Olivert Riera
2015-02-08 15:07 ` [Buildroot] [PATCH 1/3] glibc: add version 2.21 Vicente Olivert Riera
2015-02-08 15:39   ` Yann E. MORIN
2015-02-08 17:20   ` Baruch Siach
2015-02-08 17:29     ` Yann E. MORIN [this message]
2015-02-08 22:55   ` Peter Korsgaard
2015-02-09 10:39     ` Markos Chandras
2015-02-09 12:26       ` Peter Korsgaard
2015-02-09 23:37     ` Ezequiel Garcia
2015-02-10  0:07   ` Ezequiel Garcia
2015-02-10  6:05     ` Peter Korsgaard
2015-02-08 15:07 ` [Buildroot] [PATCH 2/3] glibc: set version 2.20 as default Vicente Olivert Riera
2015-02-08 15:40   ` Yann E. MORIN
2015-02-08 15:07 ` [Buildroot] [PATCH 3/3] glibc: remove version 2.19 Vicente Olivert Riera
2015-02-08 15:41   ` Yann E. MORIN
2015-02-08 22:52 ` [Buildroot] [PATCH 0/3] glibc: bump version to 2.21 Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150208172913.GM4028@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox